Rachid Mrad
dcda5d026a
merge
2024-01-09 16:51:42 -05:00
Rachid Mrad
2c4ad262b4
Change layout architecture of legend + delete button to fix accessibility issue (legend needs to be direct child of fieldset)
2024-01-09 16:26:28 -05:00
David Kennedy
d48572e193
formatting
2024-01-09 15:08:11 -05:00
David Kennedy
19866f2d9a
Merge branch 'dk/661-other-contacts' into dk/903-delete-other-contacts
2024-01-09 14:58:35 -05:00
David Kennedy
7e6a1c4188
fixed test_delete_other_contact_sets_visible_empty_form_as_required_after_failed_submit
2024-01-09 14:45:13 -05:00
Rachid Mrad
bf5867ffc9
Merge
2024-01-09 14:37:56 -05:00
Rachid Mrad
3895a04879
cleanup and lint
2024-01-09 13:17:43 -05:00
Rachid Mrad
f2b12e01d0
Fix DELETE getter in form's clean, add test_delete_other_contact_does_not_allow_zero_contacts, cleanup
2024-01-09 13:03:23 -05:00
Michelle Rago
e2af9ac153
Text updates to success and error messages ( #1593 )
...
* Text updates to error messages
* Error message text updates
* Error message text updates
* Update to success message text for name server update
* Update to DS data removal warning text
* Success message text updates
* typo fix
* Text updates for success messages
* Update 403 text
* Update 500 error text
* Using example.com instead of city.com
* Putting the period outside the link
* Updated name server minimum error text
* Trying to fix python errors
* Update name server minimum text
* Update errors.py
* Trying to fix python errors
* Update errors.py
* Making error messages agree
* Minor text change
* Fix black error message formatting
* Fixed tests and reformatted
* One last fix?
---------
Co-authored-by: Neil Martinsen-Burrell <neil.martinsen-burrell@gsa.gov>
2024-01-09 09:19:51 -05:00
Rachid Mrad
eb7498b28e
Fixed test_delete_other_contact, wip test_delete_other_contact_sets_visible_empty_form_as_required_after_failed_submit
2024-01-09 00:12:27 -05:00
Rachid Mrad
fffa489bb8
WIP test_application_delete_other_contact
2024-01-08 19:14:03 -05:00
Rachid Mrad
93c1f066f7
Fix typo in comment
2024-01-08 18:15:21 -05:00
Rachid Mrad
510b8e3f15
Handle the word 'optional' in nameservers labels on add and delete
2024-01-08 18:13:54 -05:00
Rachid Mrad
39f594f4e4
Clean up and comment JS
2024-01-08 17:28:09 -05:00
David Kennedy
fd1bd09f6c
removed extraneous logging and code from views/application.py and application_wizard.py
2024-01-08 17:08:53 -05:00
David Kennedy
080d59c0b5
updated comments and removed extraneous code and logging from application_wizard
2024-01-08 16:59:34 -05:00
Rachid Mrad
79519f9566
Handle fieldset headers in JS delete and add, fix the page jump on delete first form through JS, remove form level errors from template and form
2024-01-08 16:33:41 -05:00
David Kennedy
7c6e8c891a
added debugging (to be removed later), fixed required attributes not showing on new forms in formset
2024-01-08 14:35:21 -05:00
David Kennedy
b00149f2ae
non_form_errors raised to the template and displayed to users
2024-01-08 12:08:49 -05:00
Rachid Mrad
fd4204a415
Tweak required on no other contacts
2024-01-08 11:38:38 -05:00
David Kennedy
e90474cab1
remove errors from being returned if forms are deleted, js to hide deleted forms on page load
2024-01-08 06:33:26 -05:00
Rachid Mrad
dcce354224
JS wip
2024-01-05 18:22:51 -05:00
David Kennedy
4be47912dc
add hidden input deletion_widget
2024-01-05 16:30:41 -05:00
David Kennedy
6692eebfe3
DELETE working on backend
2024-01-05 16:21:32 -05:00
David Kennedy
eae2eda4f2
started delete, added can_delete to form and template, adding logging to find source of errors
2024-01-05 12:58:28 -05:00
Neil MartinsenBurrell
f8d2898836
Merge pull request #1589 from cisagov/nmb/1572-submission-date-emails
...
Use submission_date in application emails
2024-01-05 12:38:44 -05:00
Rachid Mrad
13151c9368
Fix the Add functionality on the Other Contacts formset
2024-01-05 12:22:15 -05:00
David Kennedy
2a64230c91
getting started
2024-01-05 11:30:52 -05:00
David Kennedy
3499cc3ba0
fixed bug in test_if_more_than_one_join
2024-01-05 06:36:03 -05:00
David Kennedy
185c1f0cb6
Merge branch 'main' into dk/661-other-contacts
2024-01-05 06:13:06 -05:00
David Kennedy
01d17269f3
account for apostrophes in tests
2024-01-05 06:12:06 -05:00
David Kennedy
3ce4aa6b5f
comments, apostrophes, and minor refactors, oh my
2024-01-05 05:35:58 -05:00
David Kennedy
8491f24ea9
adding code comments
2024-01-05 04:59:56 -05:00
David Kennedy
f1895dbb71
fixed an error that occurred when deleting a contact with a User, also fixed form field error helper text in template
2024-01-05 04:39:36 -05:00
Rachid Mrad
4365141b5e
linter
2024-01-04 20:20:31 -05:00
Rachid Mrad
913f918787
linter
2024-01-04 20:14:37 -05:00
Rachid Mrad
a313c5496b
Clean up
2024-01-04 19:46:43 -05:00
Rachid Mrad
5c1147c355
The rest of the Other Contacts unit tests
2024-01-04 19:13:59 -05:00
dave-kennedy-ecs
653a958950
Merge pull request #1566 from cisagov/dk/1485-application-intro
...
Issue #1485 - Intro acknowledgement page added to domain request form for new requests only
2024-01-04 17:54:57 -05:00
Rachid Mrad
3802380490
Testing views
2024-01-04 17:52:07 -05:00
David Kennedy
196e65dd7b
Merge branch 'main' into dk/1485-application-intro
2024-01-04 17:48:46 -05:00
dave-kennedy-ecs
90bd0f2894
Merge pull request #1564 from cisagov/dk/1359-security-email
...
Issue #1359 - Show saved security contact email if registry is down
2024-01-04 17:31:39 -05:00
David Kennedy
5648397e0e
Merge branch 'main' into dk/1359-security-email
2024-01-04 17:20:05 -05:00
David Kennedy
ad4a4511b2
refactor of fetch_cache
2024-01-04 17:19:04 -05:00
David Kennedy
c3d1603a5a
more apostrophe
2024-01-04 17:12:04 -05:00
David Kennedy
38ea3eade7
apostrophe
2024-01-04 17:03:12 -05:00
Rachid Mrad
a76d4c9da1
Testing views
2024-01-04 16:56:31 -05:00
Neil Martinsen-Burrell
37189a5ff8
Use submission_date in application emails
2024-01-04 14:54:42 -06:00
Michelle Rago
484bb689af
Tiny text updates
2024-01-04 15:23:30 -05:00
David Kennedy
d854f8327f
fixed display in application review page
2024-01-04 12:33:19 -05:00
