Seamus Johnston
0e3f68622f
Bypass Django internal form rendering
...
The purpose of this change is to allow direct use of Django templates
to make edits to how form fields and labels are rendered, while
retaining the validation logic provided by Django's extensive field and
widget library.
This commit additional contains:
- Remove `REQUIRED_SUFFIX`, as it is handled by the templates now
- Remove `required=True` from form fields, as this is the default
- Remove `required=False` from fields where it was added as workaround
for conditionally required questions which Django form wizard
couldn't handle
- Replace `clean_is_policy_acknowledged` with `error_messages` dict
- Remove duplicate nil entry for Federal Agency dropdown
- Update `DOMAIN_REGEX` to match whole string
- Subtle changes to `is_valid` and `get_forms` in ApplicationWizard to
reduce database calls and use form object's initial data correctly
2023-02-02 15:06:23 -06:00
Seamus Johnston
1d6b0da391
Highlight broken links
2023-02-02 14:14:45 -06:00
Neil MartinsenBurrell
2de82b597e
Merge pull request #382 from cisagov/nmb/tribal-question
...
Add tribal government questions
2023-01-30 14:59:42 -06:00
Neil Martinsen-Burrell
d4ac5d92f1
Add form test and fix linting/test merge errors
2023-01-30 14:54:09 -06:00
Neil Martinsen-Burrell
59c67a70d2
Revert "Mark test as an expected failure for now."
...
This reverts commit 604557e96c
2023-01-30 11:22:04 -06:00
Neil Martinsen-Burrell
b36dbf8ec1
Revert "Unrecognized tribal government more explanation"
...
This reverts commit 2cd53dc4c8
2023-01-30 11:20:59 -06:00
Neil Martinsen-Burrell
78fb98bf56
Fix linting error
2023-01-30 11:15:15 -06:00
Neil MartinsenBurrell
e086fcd9a2
Simplify None/False logic
...
Co-authored-by: Seamus Johnston <seamus.johnston@gsa.gov>
2023-01-30 10:00:19 -06:00
Neil Martinsen-Burrell
e9b678e879
Merge branch 'main' into nmb/tribal-question
2023-01-25 12:05:44 -06:00
Neil Martinsen-Burrell
0c318e0eea
Fix linting
2023-01-25 11:55:46 -06:00
Igor Korenfeld
34c3ca54a0
Merge pull request #381 from cisagov/ik/dynamic-helper-text-2
...
Dynamic example text – part 2
2023-01-25 12:53:54 -05:00
Neil Martinsen-Burrell
cc510138cb
Fix migrations merge conflict
2023-01-25 11:48:55 -06:00
Neil Martinsen-Burrell
c5ada0437f
Merge branch 'main' into nmb/tribal-question
2023-01-25 11:45:49 -06:00
igorkorenfeld
7b58242433
Fix failing tests after merge
2023-01-25 12:44:31 -05:00
igorkorenfeld
c6e9d0092c
Merge branch 'main' into ik/dynamic-helper-text-2
2023-01-25 12:14:57 -05:00
Neil Martinsen-Burrell
604557e96c
Mark test as an expected failure for now.
2023-01-24 15:36:48 -06:00
Seamus Johnston
1a52664e73
Merge pull request #365 from cisagov/sspj/dynamic-fields
...
Add ability for additional items under certain fields
2023-01-24 14:37:20 -06:00
Neil Martinsen-Burrell
2cd53dc4c8
Unrecognized tribal government more explanation
2023-01-24 13:24:06 -06:00
igorkorenfeld
0337bbc536
Update AO example for tribal orgs to match latest
2023-01-24 12:35:16 -05:00
Seamus Johnston
6a7dbbab95
Fix rebase errors
2023-01-24 10:20:44 -06:00
Seamus Johnston
0f87d9ea9a
Respond to PR feedback
2023-01-24 10:09:36 -06:00
Seamus Johnston
f6c70f88a9
Add more code comments
...
Co-authored-by: Neil MartinsenBurrell <neil.martinsen-burrell@gsa.gov>
2023-01-24 10:03:42 -06:00
Seamus Johnston
f54276d82b
Implement dynamic questions with formsets
2023-01-24 10:03:39 -06:00
igorkorenfeld
04e7eba983
Fix linter issue
2023-01-23 17:52:45 -05:00
igorkorenfeld
c0a0ae41e0
Remove indivdiual example files for ao
2023-01-23 17:50:06 -05:00
igorkorenfeld
e0a571bb69
Move all AO text into one file
2023-01-23 17:46:48 -05:00
igorkorenfeld
45dcc07be8
Add test for dynamic text on dotgov domain page
2023-01-23 17:13:33 -05:00
igorkorenfeld
4e45f113c1
Update include file path in the dotgov domain page template
2023-01-23 16:51:16 -05:00
igorkorenfeld
fc59e0b9cf
Move is_federal to base class
2023-01-23 16:50:13 -05:00
igorkorenfeld
3be3dddbbc
Add all dotgov example text to domain_example include
2023-01-23 16:45:15 -05:00
Neil Martinsen-Burrell
2c66b3728e
Tribal government question, still needs follow-up 'more information' page
2023-01-23 15:04:24 -06:00
Igor Korenfeld
c0c726e5fa
Merge pull request #378 from cisagov/ik/dynamic-helper-text
...
Dynamic helper text for Authorizing Official
2023-01-23 13:20:10 -05:00
igorkorenfeld
e65b19ae0a
Update text for ao example test
2023-01-23 13:03:57 -05:00
igorkorenfeld
d069f7ed17
Change bolded text in city example
2023-01-23 12:55:43 -05:00
igorkorenfeld
2cf71afd47
Address PR comment: replace abbreviations
2023-01-23 12:44:19 -05:00
igorkorenfeld
e44d4c6c25
Fix remaining linting issue
2023-01-20 18:04:40 -05:00
igorkorenfeld
ac93621221
Fix linting error
2023-01-20 17:40:00 -05:00
Logan McDonald
bed87212d2
fix issue confusing head vs base branch syntax ( #377 )
...
* fix issue confusing head vs base branch syntax
* try to add pr comments
2023-01-20 14:02:39 -08:00
Michelle Rago
76d2810a8a
Mr/error messages ( #369 )
...
* Make error messages match google doc.
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Update application_wizard.py
* Fix tests and re-format source code
* Update application_wizard.py
* Re-format code to make tests pass
Co-authored-by: Neil MartinsenBurrell <neil.martinsen-burrell@gsa.gov>
2023-01-20 15:03:45 -05:00
igorkorenfeld
0f53fb7c68
Change fields passed to ao context to only the releveant ones
2023-01-20 14:56:15 -05:00
igorkorenfeld
9678801787
Add test for ao dynamic text
2023-01-20 14:34:59 -05:00
Logan McDonald
508e5384cb
Create dev sandboxes scripts and first sandbox ( #370 )
...
* Add templates, scripts, and process documentation for creating and destroying developer sandboxes
* Create developer sandbox 'lmm' infrastructure
* fix up newlines
* fix action syntax pull_request
* add a line about the public.crt to developer docs
* add docs about branch conventions
* add new developer sandbox 'ik' infrastructure
* Add new developer sandbox 'nmb' infrastructure
* Add new developer sandbox 'sspj' infrastructure
* Add new developer sandbox 'mr' infrastructure
* make github actions dynamic by environment
* trying something out with dynamic github action for dev sandbox
* consolidate github actions to dynamic action
* try out run name
* combo run name and name
* respond to comments
2023-01-20 09:50:36 -08:00
igorkorenfeld
af4ea16a63
Add conditional logic to ao template
2023-01-20 12:33:06 -05:00
igorkorenfeld
e15bdabb4b
Adjust spacing and styling of subheaders for ao examples
2023-01-19 14:25:31 -05:00
igorkorenfeld
248a775ee8
Add content for all ao examples
2023-01-19 14:24:48 -05:00
Logan McDonald
6a54bf1ff4
Create new stable environment ( #367 )
...
update documentation for environments and setup new stable environment
2023-01-17 13:54:30 -08:00
Igor Korenfeld
80f8748f39
Merge pull request #366 from cisagov/ik/next-button-text
...
Change next and save button text
2023-01-17 14:10:08 -05:00
igorkorenfeld
0e52677bc7
Change next and save button text
2023-01-17 13:37:00 -05:00
Neil MartinsenBurrell
9d88026185
Merge pull request #361 from cisagov/nmb/type-of-work
...
Add Type of Work section for special districts/interstate orgs
2023-01-12 10:31:44 -06:00
Neil Martinsen-Burrell
fc6bff611b
Review feedback: required questions
2023-01-12 10:28:55 -06:00
