zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-21 10:16:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

fixed create_host bug not properly submitting ip version for v6; refactored update_host as well

Browse source
This commit is contained in:
David Kennedy 2023-10-25 22:43:41 -04:00
parent 167cb9d995
commit eedd5d7dbf
No known key found for this signature in database
GPG key ID: 6528A5386E66B96B
1 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/registrar/models/domain.py
View file

@ -261,7 +261,13 @@ class Domain(TimeStampedModel, DomainHelper):
doesn't add the created host to the domain doesn't add the created host to the domain
returns ErrorCode (int)""" returns ErrorCode (int)"""
if addrs is not None and addrs != []: if addrs is not None and addrs != []:
addresses = [epp.Ip(addr=addr) for addr in addrs] addresses = [
epp.Ip(
addr=addr,
ip="v6" if self.is_ipv6(addr) else None
)
for addr in addrs
]
request = commands.CreateHost(name=host, addrs=addresses) request = commands.CreateHost(name=host, addrs=addresses)
else: else:
request = commands.CreateHost(name=host) request = commands.CreateHost(name=host)
@ -1541,10 +1547,12 @@ class Domain(TimeStampedModel, DomainHelper):
return [] return []
for ip_addr in ip_list: for ip_addr in ip_list:
if self.is_ipv6(ip_addr): edited_ip_list.append(
edited_ip_list.append(epp.Ip(addr=ip_addr, ip="v6")) epp.Ip(
else: # default ip addr is v4 addr=ip_addr,
edited_ip_list.append(epp.Ip(addr=ip_addr)) ip="v6" if self.is_ipv6(ip_addr) else None
)
)
return edited_ip_list return edited_ip_list