From eedd5d7dbff003b0c5597f51f86e5eb8f97a0016 Mon Sep 17 00:00:00 2001 From: David Kennedy Date: Wed, 25 Oct 2023 22:43:41 -0400 Subject: [PATCH] fixed create_host bug not properly submitting ip version for v6; refactored update_host as well --- src/registrar/models/domain.py | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/registrar/models/domain.py b/src/registrar/models/domain.py index 522590e69..8215d0a7a 100644 --- a/src/registrar/models/domain.py +++ b/src/registrar/models/domain.py @@ -261,7 +261,13 @@ class Domain(TimeStampedModel, DomainHelper): doesn't add the created host to the domain returns ErrorCode (int)""" if addrs is not None and addrs != []: - addresses = [epp.Ip(addr=addr) for addr in addrs] + addresses = [ + epp.Ip( + addr=addr, + ip="v6" if self.is_ipv6(addr) else None + ) + for addr in addrs + ] request = commands.CreateHost(name=host, addrs=addresses) else: request = commands.CreateHost(name=host) @@ -1541,10 +1547,12 @@ class Domain(TimeStampedModel, DomainHelper): return [] for ip_addr in ip_list: - if self.is_ipv6(ip_addr): - edited_ip_list.append(epp.Ip(addr=ip_addr, ip="v6")) - else: # default ip addr is v4 - edited_ip_list.append(epp.Ip(addr=ip_addr)) + edited_ip_list.append( + epp.Ip( + addr=ip_addr, + ip="v6" if self.is_ipv6(ip_addr) else None + ) + ) return edited_ip_list