zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-21 10:16:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Review feedback: exists and better test

Browse source 
Signed-off-by: Neil Martinsen-Burrell <neil.martinsen-burrell@gsa.gov>
This commit is contained in:
Neil Martinsen-Burrell 2023-03-17 13:44:13 -05:00
parent 2451cd8d11
commit 78500ef74c
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/registrar/tests/test_views.py
View file

@ -78,8 +78,8 @@ class LoggedInTests(TestWithUser):
def test_home_lists_domains(self): def test_home_lists_domains(self):
response = self.client.get("/") response = self.client.get("/")
self.assertNotContains(response, "igorville.gov")
domain, _ = Domain.objects.get_or_create(name="igorville.gov") domain, _ = Domain.objects.get_or_create(name="igorville.gov")
self.assertNotContains(response, "igorville.gov")
role, _ = UserDomainRole.objects.get_or_create( role, _ = UserDomainRole.objects.get_or_create(
user=self.user, domain=domain, role=UserDomainRole.Roles.ADMIN user=self.user, domain=domain, role=UserDomainRole.Roles.ADMIN
) )

7
src/registrar/views/utility/mixins.py
View file

@ -28,12 +28,9 @@ class DomainPermission(PermissionsLoginMixin):
return False return False
# user needs to have a role on the domain # user needs to have a role on the domain
try: if not UserDomainRole.objects.filter(
UserDomainRole.objects.get(
user=self.request.user, domain__id=self.kwargs["pk"] user=self.request.user, domain__id=self.kwargs["pk"]
) ).exists():
except UserDomainRole.DoesNotExist:
# can't find the role
return False return False
# if we need to check more about the nature of role, do it here. # if we need to check more about the nature of role, do it here.