diff --git a/src/registrar/tests/test_views.py b/src/registrar/tests/test_views.py index dac35b194..22f2e2ac9 100644 --- a/src/registrar/tests/test_views.py +++ b/src/registrar/tests/test_views.py @@ -78,8 +78,8 @@ class LoggedInTests(TestWithUser): def test_home_lists_domains(self): response = self.client.get("/") - self.assertNotContains(response, "igorville.gov") domain, _ = Domain.objects.get_or_create(name="igorville.gov") + self.assertNotContains(response, "igorville.gov") role, _ = UserDomainRole.objects.get_or_create( user=self.user, domain=domain, role=UserDomainRole.Roles.ADMIN ) diff --git a/src/registrar/views/utility/mixins.py b/src/registrar/views/utility/mixins.py index a8b347181..71129a1f6 100644 --- a/src/registrar/views/utility/mixins.py +++ b/src/registrar/views/utility/mixins.py @@ -28,12 +28,9 @@ class DomainPermission(PermissionsLoginMixin): return False # user needs to have a role on the domain - try: - UserDomainRole.objects.get( - user=self.request.user, domain__id=self.kwargs["pk"] - ) - except UserDomainRole.DoesNotExist: - # can't find the role + if not UserDomainRole.objects.filter( + user=self.request.user, domain__id=self.kwargs["pk"] + ).exists(): return False # if we need to check more about the nature of role, do it here.