mirror of
https://github.com/cisagov/manage.get.gov.git
synced 2025-07-19 17:25:56 +02:00
Review feedback: exists and better test
Signed-off-by: Neil Martinsen-Burrell <neil.martinsen-burrell@gsa.gov>
This commit is contained in:
parent
2451cd8d11
commit
78500ef74c
2 changed files with 4 additions and 7 deletions
|
@ -78,8 +78,8 @@ class LoggedInTests(TestWithUser):
|
|||
|
||||
def test_home_lists_domains(self):
|
||||
response = self.client.get("/")
|
||||
self.assertNotContains(response, "igorville.gov")
|
||||
domain, _ = Domain.objects.get_or_create(name="igorville.gov")
|
||||
self.assertNotContains(response, "igorville.gov")
|
||||
role, _ = UserDomainRole.objects.get_or_create(
|
||||
user=self.user, domain=domain, role=UserDomainRole.Roles.ADMIN
|
||||
)
|
||||
|
|
|
@ -28,12 +28,9 @@ class DomainPermission(PermissionsLoginMixin):
|
|||
return False
|
||||
|
||||
# user needs to have a role on the domain
|
||||
try:
|
||||
UserDomainRole.objects.get(
|
||||
user=self.request.user, domain__id=self.kwargs["pk"]
|
||||
)
|
||||
except UserDomainRole.DoesNotExist:
|
||||
# can't find the role
|
||||
if not UserDomainRole.objects.filter(
|
||||
user=self.request.user, domain__id=self.kwargs["pk"]
|
||||
).exists():
|
||||
return False
|
||||
|
||||
# if we need to check more about the nature of role, do it here.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue