zydronium/manage.get.gov
1
0
Fork 0
mirror of https://github.com/cisagov/manage.get.gov.git synced 2025-07-12 05:58:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

Review feedback: fix user management display, use h2

Browse source
This commit is contained in:
Neil Martinsen-Burrell 2023-06-01 11:45:40 -05:00
parent 320c2b5e18
commit 5f86a0f83c
No known key found for this signature in database
GPG key ID: 6A3C818CC10D0184
2 changed files with 17 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/registrar/templates/domain_detail.html
View file

@ -21,13 +21,13 @@
{% include "includes/summary_item.html" with title='Authorizing official' value=domain.domain_info.authorizing_official contact='true' edit_link=url %} {% include "includes/summary_item.html" with title='Authorizing official' value=domain.domain_info.authorizing_official contact='true' edit_link=url %}
{% url 'todo' as url %} {% url 'todo' as url %}
{% include "includes/summary_item.html" with title='Your contact information' value='---TODO---' edit_link=url %} {% include "includes/summary_item.html" with title='Your contact information' value=request.user.contact edit_link=url %}
{% url 'domain-security-email' pk=domain.id as url %} {% url 'domain-security-email' pk=domain.id as url %}
{% include "includes/summary_item.html" with title='Security email' value=domain.security_email edit_link=url %} {% include "includes/summary_item.html" with title='Security email' value=domain.security_email edit_link=url %}
{% url 'domain-users' pk=domain.id as url %} {% url 'domain-users' pk=domain.id as url %}
{% include "includes/summary_item.html" with title='User management' users='true' value=domain.permissions.all edit_link=url %} {% include "includes/summary_item.html" with title='User management' users='true' list=True value=domain.permissions.all edit_link=url %}
</div> </div>
{% endblock %} {# domain_content #} {% endblock %} {# domain_content #}

14
src/registrar/templates/includes/summary_item.html
View file

@ -1,13 +1,13 @@
{% load static url_helpers %} {% load static url_helpers %}
<section class="summary-item margin-top-3"> <section class="summary-item margin-top-3">
<hr class="" /> <hr class="" aria-hidden="true" />
<p class="summary-item__title <h2 class="summary-item__title
text-primary-dark text-semibold text-primary-dark text-semibold
margin-top-0 margin-bottom-05" margin-top-0 margin-bottom-05"
> >
{{ title }} {{ title }}
</p> </h2>
{% if address %} {% if address %}
{% include "includes/organization_address.html" with organization=value %} {% include "includes/organization_address.html" with organization=value %}
{% elif contact %} {% elif contact %}
@ -32,11 +32,19 @@
{% endif %} {% endif %}
{% elif list %} {% elif list %}
{% if value|length == 1 %} {% if value|length == 1 %}
{% if users %}
<p class="margin-top-0">{{ value.0.user.email }} </p>
{% else %}
<p class="margin-top-0">{{ value | first }} </p> <p class="margin-top-0">{{ value | first }} </p>
{% endif %}
{% else %} {% else %}
<ul class="usa-list margin-top-0"> <ul class="usa-list margin-top-0">
{% for item in value %} {% for item in value %}
{% if users %}
<li>{{ item.user.email }}</li>
{% else %}
<li>{{ item }}</li> <li>{{ item }}</li>
{% endif %}
{% empty %} {% empty %}
<li>None</li> <li>None</li>
{% endfor %}</ul></p> {% endfor %}</ul></p>