From 5f86a0f83cea0219ede84ed0b7dde9e757418a8c Mon Sep 17 00:00:00 2001
From: Neil Martinsen-Burrell <neil.martinsen-burrell@gsa.gov>
Date: Thu, 1 Jun 2023 11:45:40 -0500
Subject: [PATCH] Review feedback: fix user management display, use h2

---
 src/registrar/templates/domain_detail.html    |  4 ++--
 .../templates/includes/summary_item.html      | 22 +++++++++++++------
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/registrar/templates/domain_detail.html b/src/registrar/templates/domain_detail.html
index 97b15207a..700cb3fee 100644
--- a/src/registrar/templates/domain_detail.html
+++ b/src/registrar/templates/domain_detail.html
@@ -21,13 +21,13 @@
     {% include "includes/summary_item.html" with title='Authorizing official' value=domain.domain_info.authorizing_official contact='true' edit_link=url %}
 
     {% url 'todo' as url %}
-    {% include "includes/summary_item.html" with title='Your contact information' value='---TODO---' edit_link=url %}
+    {% include "includes/summary_item.html" with title='Your contact information' value=request.user.contact edit_link=url %}
 
     {% url 'domain-security-email' pk=domain.id as url %}
     {% include "includes/summary_item.html" with title='Security email' value=domain.security_email edit_link=url %}
 
     {% url 'domain-users' pk=domain.id as url %}
-    {% include "includes/summary_item.html" with title='User management' users='true' value=domain.permissions.all edit_link=url %}
+    {% include "includes/summary_item.html" with title='User management' users='true' list=True value=domain.permissions.all edit_link=url %}
 
   </div>
 {% endblock %}  {# domain_content #}
diff --git a/src/registrar/templates/includes/summary_item.html b/src/registrar/templates/includes/summary_item.html
index 9de8b3c6c..9efa0e2a4 100644
--- a/src/registrar/templates/includes/summary_item.html
+++ b/src/registrar/templates/includes/summary_item.html
@@ -1,13 +1,13 @@
 {% load static url_helpers %}
 
 <section class="summary-item margin-top-3">
-  <hr class="" />
-  <p class="summary-item__title 
+  <hr class="" aria-hidden="true" />
+  <h2 class="summary-item__title
             text-primary-dark text-semibold
             margin-top-0 margin-bottom-05"
-  > 
-  {{ title }} 
-  </p>
+  >
+  {{ title }}
+  </h2>
   {% if address %}
     {% include "includes/organization_address.html" with organization=value %}
   {% elif contact %}
@@ -32,11 +32,19 @@
     {% endif %}
   {% elif list %}
     {% if value|length == 1 %}
-      <p class="margin-top-0">{{ value | first }} </p>
+        {% if users %}
+          <p class="margin-top-0">{{ value.0.user.email }} </p>
+        {% else %}
+          <p class="margin-top-0">{{ value | first }} </p>
+        {% endif %}
     {% else %}
       <ul class="usa-list margin-top-0">
         {% for item in value %}
-         <li>{{ item }}</li>
+        {% if users %}
+          <li>{{ item.user.email }}</li>
+        {% else %}
+          <li>{{ item }}</li>
+        {% endif %}
         {% empty %}
          <li>None</li>
         {% endfor %}</ul></p>