PR feedback

This commit is contained in:
CocoByte 2024-08-19 16:32:29 -06:00
parent 357756214f
commit 1cab199eba
No known key found for this signature in database
GPG key ID: BBFAA2526384C97F
3 changed files with 6 additions and 6 deletions

View file

@ -222,7 +222,7 @@ class DomainRequestAdminForm(forms.ModelForm):
"other_contacts": NoAutocompleteFilteredSelectMultiple("other_contacts", False), "other_contacts": NoAutocompleteFilteredSelectMultiple("other_contacts", False),
} }
labels = { labels = {
"action_needed_reason_email": "E-mail", "action_needed_reason_email": "Email",
} }
def __init__(self, *args, **kwargs): def __init__(self, *args, **kwargs):

View file

@ -565,13 +565,13 @@ function initializeWidgetOnList(list, parentId) {
} }
else { else {
// Show editable view // Show editable view
showEmail(true) showEmail(canEdit=true)
} }
}); });
confirmEditEmailButton.addEventListener("click", function() { confirmEditEmailButton.addEventListener("click", function() {
// Show editable view // Show editable view
showEmail(true) showEmail(canEdit=true)
}); });
// Event delegation for data-close-modal buttons // Event delegation for data-close-modal buttons
@ -641,7 +641,7 @@ function initializeWidgetOnList(list, parentId) {
} }
else { else {
// Always show readonly view of email to start // Always show readonly view of email to start
showEmail(false) showEmail(canEdit=false)
} }
} else { } else {
// Hide email preview and show this text instead // Hide email preview and show this text instead
@ -652,7 +652,7 @@ function initializeWidgetOnList(list, parentId) {
// Shows a readonly preview of the email with updated messaging to indicate this email was sent // Shows a readonly preview of the email with updated messaging to indicate this email was sent
function showEmailAlreadySentView() function showEmailAlreadySentView()
{ {
showEmail(false) showEmail(canEdit=false)
hideElement(actionNeededEmailHeader) hideElement(actionNeededEmailHeader)
showElement(actionNeededEmailHeaderOnSave) showElement(actionNeededEmailHeaderOnSave)
actionNeededEmailFooter.innerHTML = "This email has been sent to the creator of this request"; actionNeededEmailFooter.innerHTML = "This email has been sent to the creator of this request";

View file

@ -231,7 +231,7 @@ This is using a custom implementation fieldset.html (see admin/fieldset.html)
<span>Edit email</span> <span>Edit email</span>
</button> </button>
</div> </div>
<textarea cols="40" rows="10" class="vLargeTextField" id="action-needed-reason-email-readonly-textarea" readonly> <textarea cols="40" rows="10" class="vLargeTextField dja-readonly-textarea-container" id="action-needed-reason-email-readonly-textarea" readonly>
{{ field.field.value|linebreaks }} {{ field.field.value|linebreaks }}
</textarea> </textarea>
</div> </div>