From 1cab199eba30059b87eca0b5745376472d378bc4 Mon Sep 17 00:00:00 2001 From: CocoByte Date: Mon, 19 Aug 2024 16:32:29 -0600 Subject: [PATCH] PR feedback --- src/registrar/admin.py | 2 +- src/registrar/assets/js/get-gov-admin.js | 8 ++++---- .../django/admin/includes/detail_table_fieldset.html | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/registrar/admin.py b/src/registrar/admin.py index bb1f7ffd3..3b9872e48 100644 --- a/src/registrar/admin.py +++ b/src/registrar/admin.py @@ -222,7 +222,7 @@ class DomainRequestAdminForm(forms.ModelForm): "other_contacts": NoAutocompleteFilteredSelectMultiple("other_contacts", False), } labels = { - "action_needed_reason_email": "E-mail", + "action_needed_reason_email": "Email", } def __init__(self, *args, **kwargs): diff --git a/src/registrar/assets/js/get-gov-admin.js b/src/registrar/assets/js/get-gov-admin.js index cdfa4778a..23413ade1 100644 --- a/src/registrar/assets/js/get-gov-admin.js +++ b/src/registrar/assets/js/get-gov-admin.js @@ -565,13 +565,13 @@ function initializeWidgetOnList(list, parentId) { } else { // Show editable view - showEmail(true) + showEmail(canEdit=true) } }); confirmEditEmailButton.addEventListener("click", function() { // Show editable view - showEmail(true) + showEmail(canEdit=true) }); // Event delegation for data-close-modal buttons @@ -641,7 +641,7 @@ function initializeWidgetOnList(list, parentId) { } else { // Always show readonly view of email to start - showEmail(false) + showEmail(canEdit=false) } } else { // Hide email preview and show this text instead @@ -652,7 +652,7 @@ function initializeWidgetOnList(list, parentId) { // Shows a readonly preview of the email with updated messaging to indicate this email was sent function showEmailAlreadySentView() { - showEmail(false) + showEmail(canEdit=false) hideElement(actionNeededEmailHeader) showElement(actionNeededEmailHeaderOnSave) actionNeededEmailFooter.innerHTML = "This email has been sent to the creator of this request"; diff --git a/src/registrar/templates/django/admin/includes/detail_table_fieldset.html b/src/registrar/templates/django/admin/includes/detail_table_fieldset.html index ace7b7e8f..ea2c0e560 100644 --- a/src/registrar/templates/django/admin/includes/detail_table_fieldset.html +++ b/src/registrar/templates/django/admin/includes/detail_table_fieldset.html @@ -231,7 +231,7 @@ This is using a custom implementation fieldset.html (see admin/fieldset.html) Edit email -