Commit graph

11488 commits

Author SHA1 Message Date
oleghasjanov
69dca2ca73 fixed test 2025-07-31 14:03:29 +03:00
oleghasjanov
618f2f5aed Fix: Align domain contact duplication logic and notifications
This commit refines the contact duplication checks and notification messages for domain creation and updates, ensuring consistency and addressing a bug in domain updates.

**Key Changes:**

*   **Consistent Duplicate Contact Handling:**
    *   The `check_for_cross_role_duplicates`, `remove_duplicate_contacts`, and `duplicate_contact?` methods are now more closely aligned between `DomainCreate` and `DomainUpdate` interactors.
    *   `DomainUpdate` now correctly uses `admin_contact_ids=` and `tech_contact_ids=` to assign filtered contacts. This resolves a `PG::UniqueViolation` error that occurred when trying to re-associate existing contacts using `_attributes=` methods.
    *   The `duplicate_contact?` method in `DomainCreate` was updated to match `DomainUpdate`, primarily checking for semantic duplicates based on attributes (name, ident, email, phone) rather than also including a `contact.code` check, which is more suitable for cross-role duplication.

*   **Standardized Notification Messages:**
    *   The `notify_about_removed_duplicates` method in both interactors now generates a more concise message: ". [Role] contact [CODE] was discarded as duplicate;" for each discarded contact.
    *   This message is appended to `domain.skipped_domain_contacts_validation`.

*   **EPP & REPP Response Updates:**
    *   The `message` method in `Repp::V1::DomainsController` now correctly appends `domain.skipped_domain_contacts_validation` to the "Command completed successfully" message, ensuring it appears in REPP JSON responses for both create and update.
    *   The EPP XML views (`app/views/epp/domains/create.xml.builder` and `app/views/epp/domains/success.xml.builder`) are updated to dynamically include `domain.skipped_domain_contacts_validation` in the `<msg>` tag.

*   **Model Attribute:**
    *   Added `skipped_domain_contacts_validation` as a string attribute to the `Domain` model to store these notification messages.

*   **Test Refinements (Implicit):**
    *   The related test suite for domain updates (`test/integration/epp/domain/base_test.rb`) was being updated to reflect these logic changes and assert the correct notification messages.

These changes improve the robustness and consistency of contact management during domain operations, providing clearer feedback to users about discarded duplicate contacts.
2025-07-31 14:03:29 +03:00
Timo Võhmar
fa03ab92dd
Update CHANGELOG.md 2025-07-30 15:26:13 +03:00
Timo Võhmar
30c8d460dc
Merge pull request #2824 from internetee/2822-domain-history-shows-old-info
Fix domain history ordering and current state display
2025-07-30 15:11:49 +03:00
Timo Võhmar
c116e9e544
Update CHANGELOG.md 2025-07-29 16:19:25 +03:00
Timo Võhmar
c60d93408b
Merge pull request #2821 from internetee/update_test_coverage/accreditation_center/base_controller
Added extra test coverage for accreditation_center/base_controller
2025-07-29 16:18:42 +03:00
Timo Võhmar
15a38b4ad8
Update CHANGELOG.md 2025-07-29 16:16:47 +03:00
Timo Võhmar
97c4d3e4a7
Merge pull request #2820 from internetee/update_test_coverage/app/models/concerns/contact/archivable
added new test
2025-07-29 16:16:16 +03:00
Timo Võhmar
20b9bb365d
Update CHANGELOG.md 2025-07-29 16:15:02 +03:00
Timo Võhmar
000b4d73e2
Merge pull request #2819 from internetee/update_test_coverage/api_users_controller
Update test coverage/api users controller
2025-07-29 16:14:24 +03:00
Timo Võhmar
f1b76b5173
Update CHANGELOG.md 2025-07-29 16:13:40 +03:00
Timo Võhmar
3fab373aac
Merge pull request #2813 from internetee/update_test_coverage/zones_controller
added new tests for zones_controller
2025-07-29 16:13:05 +03:00
Timo Võhmar
98f822f847
Update CHANGELOG.md 2025-07-29 16:04:06 +03:00
Timo Võhmar
efaf363bb6
Merge pull request #2811 from internetee/update_test_coverage/validate_dnssec_job
Added extra test coverage for validate_dnssec_job
2025-07-29 16:02:47 +03:00
Timo Võhmar
eeb48fa5ba
Update CHANGELOG.md 2025-07-18 11:40:13 +03:00
Timo Võhmar
99a305e4bd
Merge pull request #2817 from internetee/fix/api_users_controller/set_test_date_to_api_user
updated set_test_date_to_api_user method on api_users_controller. #2816
2025-07-18 11:38:46 +03:00
Timo Võhmar
82d6060eb6
Update CHANGELOG.md 2025-07-18 11:31:41 +03:00
Timo Võhmar
b57598ff9a
Merge pull request #2815 from internetee/update_test_coverage/lhv_connect_transactions_controller
Added extra test coverage for LhvConnectTransactionsController
2025-07-18 11:28:24 +03:00
Timo Võhmar
62607275df
Update CHANGELOG.md 2025-07-18 11:27:17 +03:00
Timo Võhmar
9dea2aae73
Merge pull request #2800 from internetee/renovate/actions-upload-artifact-4.x
Update actions/upload-artifact action to v4.6.2
2025-07-18 11:24:34 +03:00
oleghasjanov
81e2c3aa29 refacto controllers 2025-07-17 11:31:15 +03:00
oleghasjanov
c183ff103c fixed test 2025-07-17 10:37:11 +03:00
oleghasjanov
9e5b2743a3 Fix domain history ordering and current state display
- Ensure "Current state" (pending/current domain) is always shown as the first row in domain history.
- Sort post-update domain states by updated_at descending for correct chronological order.
- Fix version navigation and sidebar highlighting for current state in domain version show view.
- Unify logic for displaying domain and contact data in both history and single version views.
- Remove legacy ObjectVersionsParser usage and handle nil @version cases gracefully.
- Refactor partials and controller logic to ensure all rows in history reflect the correct post-update state.
2025-07-17 09:07:40 +03:00
renovate[bot]
97ae39489d
Update actions/upload-artifact action to v4.6.2 2025-07-01 13:39:52 +00:00
mmeest
b6a99188c2 added new tests 2025-07-01 16:36:38 +03:00
mmeest
d5f8f07956 added new test 2025-07-01 12:08:03 +03:00
mmeest
fbfd031daa added new tests 2025-07-01 10:31:21 +03:00
mmeest
6a79721aa8 added extra tests 2025-07-01 10:31:20 +03:00
Sergei Tsõganov
0b13cfbe0f
Update certificates.md 2025-07-01 09:38:25 +03:00
mmeest
17ff97daf2 fixed typos 2025-06-27 11:33:41 +03:00
mmeest
46b1c7d057 updated set_test_date_to_api_user method 2025-06-27 11:14:06 +03:00
mmeest
249aad16b7 Added assertions for failded zone update messages 2025-06-26 13:09:16 +03:00
mmeest
ffec4fd403 updated tests 2025-06-26 11:34:50 +03:00
mmeest
416664c18d updated tests 2025-06-25 13:15:16 +00:00
Timo Võhmar
cfe1059c5f
Merge pull request #2812 from internetee/update_test_coverage/reserved_domains_test
added new tests for reserved_domains_test
2025-06-20 15:00:50 +03:00
mmeest
6166c084d3 added new tests for LhvConnectTransactionsController 2025-06-19 12:28:28 +03:00
mmeest
45c021088a updated test_prepare_validator_configures_dnsruby_resolver_with_correct_parameters 2025-06-18 15:09:09 +03:00
mmeest
e0b0b6d1a9 updated test_prepare_validator_configures_dnsruby_resolver_with_correct_parameters 2025-06-18 15:08:40 +03:00
mmeest
db98213818 added new tests 2025-06-18 12:33:18 +03:00
mmeest
9c6368bd93 resolved unrelated file 2025-06-17 16:05:15 +03:00
mmeest
3d8530db3e added new tests 2025-06-17 15:51:47 +03:00
mmeest
f26b285d7c minor update 2025-06-17 14:59:58 +03:00
mmeest
777f0ce0fd Added extra test coverage for validate_dnssec_job 2025-06-17 13:55:00 +03:00
Timo Võhmar
2bc5f50474
Update CHANGELOG.md 2025-06-06 17:00:37 +03:00
Timo Võhmar
2a192b3855
Merge pull request #2808 from internetee/update-whois-record-issue
Fix stale data in Whois update job by moving callback to after_commit
2025-06-06 16:40:29 +03:00
Timo Võhmar
f1677b01cd
Update CHANGELOG.md 2025-06-06 16:39:42 +03:00
Timo Võhmar
eb0c6e2ffb
Merge pull request #2796 from internetee/fix-end-to-end-problem
end-to-end problem: added account activity checker
2025-06-06 16:32:22 +03:00
oleghasjanov
1372f46703 clear validation event state before running test 2025-06-04 14:44:23 +03:00
oleghasjanov
2951a4da3f fixed callback 2025-06-04 14:16:12 +03:00
oleghasjanov
78ffab35c7 remove logs 2025-06-04 14:12:00 +03:00