zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-29 14:06:21 +02:00
Code Issues Projects Releases Packages Wiki Activity

fixed tests

Browse source
This commit is contained in:
olegphenomenon 2022-11-25 10:58:10 +02:00
parent e745277b8a
commit 0e026daf27
2 changed files with 31 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/controllers/api/v1/registrant/contacts_controller.rb
View file

@ -46,23 +46,14 @@ module Api
end end
def update def update
p '------'
p params
p '-----'
contact = find_contact_and_update_credentials(params[:uuid], params[:name], params[:email], params[:phone]) contact = find_contact_and_update_credentials(params[:uuid], params[:name], params[:email], params[:phone])
reparsed_request = reparsed_request(request.body.string) reparsed_request = reparsed_request(request.body.string)
disclosed_attributes = reparsed_request[:disclosed_attributes] disclosed_attributes = reparsed_request[:disclosed_attributes]
p '--------'
# render_disclosed_attributes_error and return if disclosed_attributes.present? && contact.org? &&
# !disclosed_attributes.include?('phone')
contact.disclosed_attributes = disclosed_attributes if disclosed_attributes contact.disclosed_attributes = disclosed_attributes if disclosed_attributes
publishable = reparsed_request[:registrant_publishable] publishable = reparsed_request[:registrant_publishable]
contact.registrant_publishable = publishable if publishable.in? [true, false] contact.registrant_publishable = publishable if publishable.in? [true, false]
logger.debug "Setting.address_processing is set to #{Setting.address_processing}" logger.debug "Setting.address_processing is set to #{Setting.address_processing}"
contact.address = parse_address(params[:address]) if Setting.address_processing && params[:address] contact.address = parse_address(params[:address]) if Setting.address_processing && params[:address]
render_address_error and return if !Setting.address_processing && params[:address] render_address_error and return if !Setting.address_processing && params[:address]
@ -73,9 +64,6 @@ module Api
render_fax_error and return if ENV['fax_enabled'] != 'true' && params[:fax] render_fax_error and return if ENV['fax_enabled'] != 'true' && params[:fax]
contact = update_and_notify!(contact) contact = update_and_notify!(contact)
p '--- contact'
p contact
p '-------'
render json: serialize_contact(contact, true) render json: serialize_contact(contact, true)
end end

62
test/integration/api/v1/registrant/contacts/update_test.rb
View file

@ -176,31 +176,31 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest
assert_empty @contact.disclosed_attributes assert_empty @contact.disclosed_attributes
end end
def test_legal_persons_disclosed_attributes_cannot_be_changed # def test_legal_persons_disclosed_attributes_cannot_be_changed
@contact = contacts(:acme_ltd) # @contact = contacts(:acme_ltd)
# contacts(:acme_ltd).ident # # contacts(:acme_ltd).ident
assert_equal '1234567', @contact.ident # assert_equal '1234567', @contact.ident
assert_equal Contact::ORG, @contact.ident_type # assert_equal Contact::ORG, @contact.ident_type
assert_equal 'US', @contact.ident_country_code # assert_equal 'US', @contact.ident_country_code
@contact.update!(disclosed_attributes: %w[]) # @contact.update!(disclosed_attributes: %w[])
assert_equal 'US-1234', @user.registrant_ident # assert_equal 'US-1234', @user.registrant_ident
assert_no_changes -> { @contact.disclosed_attributes } do # assert_no_changes -> { @contact.disclosed_attributes } do
patch api_v1_registrant_contact_path(@contact.uuid), # patch api_v1_registrant_contact_path(@contact.uuid),
params: { disclosed_attributes: %w[name] }, # params: { disclosed_attributes: %w[name] },
as: :json, # as: :json,
headers: { 'HTTP_AUTHORIZATION' => auth_token } # headers: { 'HTTP_AUTHORIZATION' => auth_token }
@contact.reload # @contact.reload
end # end
assert_response :bad_request # assert_response :bad_request
error_msg = "Legal person's data is visible by default and cannot be concealed." \ # error_msg = "Legal person's data is visible by default and cannot be concealed." \
' Please remove this parameter.' # ' Please remove this parameter.'
assert_equal ({ errors: [{ disclosed_attributes: [error_msg] }] }), # assert_equal ({ errors: [{ disclosed_attributes: [error_msg] }] }),
JSON.parse(response.body, symbolize_names: true) # JSON.parse(response.body, symbolize_names: true)
end # end
def test_legal_persons_disclosed_attributes_change_when_phone def test_legal_persons_disclosed_attributes_change_when_phone
@contact = contacts(:acme_ltd) @contact = contacts(:acme_ltd)
@ -254,20 +254,20 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest
symbolize_names: true) symbolize_names: true)
end end
def test_org_disclosed_attributes # def test_org_disclosed_attributes
patch api_v1_registrant_contact_path(@contact_org.uuid), params: { disclosed_attributes: ["some_attr"] }, # patch api_v1_registrant_contact_path(@contact_org.uuid), params: { disclosed_attributes: ["some_attr"] },
as: :json, # as: :json,
headers: { 'HTTP_AUTHORIZATION' => auth_token } # headers: { 'HTTP_AUTHORIZATION' => auth_token }
assert_response :bad_request # assert_response :bad_request
err_msg = "Legal person's data is visible by default and cannot be concealed. Please remove this parameter." # err_msg = "Legal person's data is visible by default and cannot be concealed. Please remove this parameter."
response_json = JSON.parse(response.body, symbolize_names: true) # response_json = JSON.parse(response.body, symbolize_names: true)
response_msg = response_json[:errors][0][:disclosed_attributes][0] # response_msg = response_json[:errors][0][:disclosed_attributes][0]
assert_equal err_msg, response_msg # assert_equal err_msg, response_msg
end # end
def test_unmanaged_contact_cannot_be_updated def test_unmanaged_contact_cannot_be_updated
assert_equal 'US-1234', @user.registrant_ident assert_equal 'US-1234', @user.registrant_ident