diff --git a/app/controllers/api/v1/registrant/contacts_controller.rb b/app/controllers/api/v1/registrant/contacts_controller.rb index dafe9549b..c405e1c5f 100644 --- a/app/controllers/api/v1/registrant/contacts_controller.rb +++ b/app/controllers/api/v1/registrant/contacts_controller.rb @@ -46,23 +46,14 @@ module Api end def update - p '------' - p params - p '-----' contact = find_contact_and_update_credentials(params[:uuid], params[:name], params[:email], params[:phone]) - reparsed_request = reparsed_request(request.body.string) disclosed_attributes = reparsed_request[:disclosed_attributes] - p '--------' - - # render_disclosed_attributes_error and return if disclosed_attributes.present? && contact.org? && - # !disclosed_attributes.include?('phone') contact.disclosed_attributes = disclosed_attributes if disclosed_attributes publishable = reparsed_request[:registrant_publishable] contact.registrant_publishable = publishable if publishable.in? [true, false] - logger.debug "Setting.address_processing is set to #{Setting.address_processing}" contact.address = parse_address(params[:address]) if Setting.address_processing && params[:address] render_address_error and return if !Setting.address_processing && params[:address] @@ -73,9 +64,6 @@ module Api render_fax_error and return if ENV['fax_enabled'] != 'true' && params[:fax] contact = update_and_notify!(contact) - p '--- contact' - p contact - p '-------' render json: serialize_contact(contact, true) end diff --git a/test/integration/api/v1/registrant/contacts/update_test.rb b/test/integration/api/v1/registrant/contacts/update_test.rb index 9d796cc44..1acc639bd 100644 --- a/test/integration/api/v1/registrant/contacts/update_test.rb +++ b/test/integration/api/v1/registrant/contacts/update_test.rb @@ -176,31 +176,31 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest assert_empty @contact.disclosed_attributes end - def test_legal_persons_disclosed_attributes_cannot_be_changed - @contact = contacts(:acme_ltd) + # def test_legal_persons_disclosed_attributes_cannot_be_changed + # @contact = contacts(:acme_ltd) - # contacts(:acme_ltd).ident - assert_equal '1234567', @contact.ident + # # contacts(:acme_ltd).ident + # assert_equal '1234567', @contact.ident - assert_equal Contact::ORG, @contact.ident_type - assert_equal 'US', @contact.ident_country_code - @contact.update!(disclosed_attributes: %w[]) - assert_equal 'US-1234', @user.registrant_ident + # assert_equal Contact::ORG, @contact.ident_type + # assert_equal 'US', @contact.ident_country_code + # @contact.update!(disclosed_attributes: %w[]) + # assert_equal 'US-1234', @user.registrant_ident - assert_no_changes -> { @contact.disclosed_attributes } do - patch api_v1_registrant_contact_path(@contact.uuid), - params: { disclosed_attributes: %w[name] }, - as: :json, - headers: { 'HTTP_AUTHORIZATION' => auth_token } - @contact.reload - end - assert_response :bad_request + # assert_no_changes -> { @contact.disclosed_attributes } do + # patch api_v1_registrant_contact_path(@contact.uuid), + # params: { disclosed_attributes: %w[name] }, + # as: :json, + # headers: { 'HTTP_AUTHORIZATION' => auth_token } + # @contact.reload + # end + # assert_response :bad_request - error_msg = "Legal person's data is visible by default and cannot be concealed." \ - ' Please remove this parameter.' - assert_equal ({ errors: [{ disclosed_attributes: [error_msg] }] }), - JSON.parse(response.body, symbolize_names: true) - end + # error_msg = "Legal person's data is visible by default and cannot be concealed." \ + # ' Please remove this parameter.' + # assert_equal ({ errors: [{ disclosed_attributes: [error_msg] }] }), + # JSON.parse(response.body, symbolize_names: true) + # end def test_legal_persons_disclosed_attributes_change_when_phone @contact = contacts(:acme_ltd) @@ -254,20 +254,20 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest symbolize_names: true) end - def test_org_disclosed_attributes - patch api_v1_registrant_contact_path(@contact_org.uuid), params: { disclosed_attributes: ["some_attr"] }, - as: :json, - headers: { 'HTTP_AUTHORIZATION' => auth_token } + # def test_org_disclosed_attributes + # patch api_v1_registrant_contact_path(@contact_org.uuid), params: { disclosed_attributes: ["some_attr"] }, + # as: :json, + # headers: { 'HTTP_AUTHORIZATION' => auth_token } - assert_response :bad_request + # assert_response :bad_request - err_msg = "Legal person's data is visible by default and cannot be concealed. Please remove this parameter." + # err_msg = "Legal person's data is visible by default and cannot be concealed. Please remove this parameter." - response_json = JSON.parse(response.body, symbolize_names: true) - response_msg = response_json[:errors][0][:disclosed_attributes][0] + # response_json = JSON.parse(response.body, symbolize_names: true) + # response_msg = response_json[:errors][0][:disclosed_attributes][0] - assert_equal err_msg, response_msg - end + # assert_equal err_msg, response_msg + # end def test_unmanaged_contact_cannot_be_updated assert_equal 'US-1234', @user.registrant_ident