google-nomulus/java/google/registry/flows
nickfelt e1c9395749 Simplify blocking of renews for domains in pending transfer
This tweaks the logic that prohibits domain renews during pending transfers to just use the regular verifyNoDisallowedStatuses() check instead of a special check on TransferData with a custom exception.  This is simpler and produces a better error message: we get "Operation disallowed by status: pendingTransfer" instead of "Object with given ID (foo.com) already has a pending transfer" (which is intended for use when denying a transfer request for an object already being transferred, not for this case).

For the record, we originally prohibited renews for domains in pending transfer because there's no good reason to do such a renew: b/12533793.  But in fact our transfer server-approve logic relies heavily on this behavior, because otherwise the domain's expiration time computed in cloneProjectedAtTime() will reflect the transfer year added to the post-renew expiration time, whereas all the transfer server approve entities (e.g. new autorenew billing event) will reflect the pre-renew expiration time at the moment the transfer was requested.  As such, it would be quite difficult to ever support a renew during pending transfer, since it would need to change many fields within the transfer server approve entities.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=150325501
2017-03-21 15:21:28 -04:00
..
async Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
contact Standardize usage of some transfer flow verification helpers 2017-03-21 15:18:33 -04:00
custom Fix an annoying Javadoc nit 2017-02-02 16:47:28 -05:00
domain Simplify blocking of renews for domains in pending transfer 2017-03-21 15:21:28 -04:00
exceptions Use StatusValue XML names in EPP error messages 2017-03-21 15:14:02 -04:00
host Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
picker Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
poll Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
session Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
soy Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
CheckApiAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppConsoleAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppController.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppException.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetrics.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestHandler.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestSource.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppTlsAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppToolAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppXmlTransformer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ExtensionManager.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Flow.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowComponent.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowModule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowRunner.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowScope.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GaeUserCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HttpSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PasswordOnlyTransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ResourceFlowUtils.java Standardize usage of some transfer flow verification helpers 2017-03-21 15:18:33 -04:00
SessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
StatelessRequestSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TlsCredentials.java Fix a deprecated method now that we are on Guava 20 2017-02-02 16:50:20 -05:00
TransactionalFlow.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
TransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00