nickfelt e1c9395749 Simplify blocking of renews for domains in pending transfer ... This tweaks the logic that prohibits domain renews during pending transfers to just use the regular verifyNoDisallowedStatuses() check instead of a special check on TransferData with a custom exception. This is simpler and produces a better error message: we get "Operation disallowed by status: pendingTransfer" instead of "Object with given ID (foo.com) already has a pending transfer" (which is intended for use when denying a transfer request for an object already being transferred, not for this case). For the record, we originally prohibited renews for domains in pending transfer because there's no good reason to do such a renew: b/12533793. But in fact our transfer server-approve logic relies heavily on this behavior, because otherwise the domain's expiration time computed in cloneProjectedAtTime() will reflect the transfer year added to the post-renew expiration time, whereas all the transfer server approve entities (e.g. new autorenew billing event) will reflect the pre-renew expiration time at the moment the transfer was requested. As such, it would be quite difficult to ever support a renew during pending transfer, since it would need to change many fields within the transfer server approve entities. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=150325501		2017-03-21 15:21:28 -04:00
..
com/google/testing/builddefs	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
google/registry	Simplify blocking of renews for domains in pending transfer	2017-03-21 15:21:28 -04:00