google-nomulus/javatests/google/registry/rdap
mountford ac822053cc Change behavior when searching contacts by name
We no longer find contacts by name if the request is not authorized to see the name.

Several changes cascade from this. Previously, the code assumed that deleted contacts might still have full names, and therefore be searchable. This is not possible in all cases, because Datastore doesn't have the right index to find deleted contacts by name with a matching registrar. However, luckily, this situation can never occur, because contacts always have their name fields nulled out when they are deleted.

So instead, we simply ignore deleted records when searching by name, knowing that none can ever match.

The tests were then changed so that deleted records look the way the really will, meaning devoid of personal information.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172776926
2017-10-24 16:53:47 -04:00
..
testdata Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
BUILD Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
RdapActionBaseTest.java Set content type for RDAP responses before setting the payload 2017-10-24 16:53:47 -04:00
RdapDomainActionTest.java Add RDAP support for deleted domains and filtering by registrar 2017-10-24 16:53:47 -04:00
RdapDomainSearchActionTest.java Add RDAP support for deleted domains and filtering by registrar 2017-10-24 16:53:47 -04:00
RdapEntityActionTest.java Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
RdapEntitySearchActionTest.java Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
RdapHelpActionTest.java Don't validate RDAP nameserver names using validateDomainName 2017-10-24 16:53:47 -04:00
RdapJsonFormatterTest.java Don't validate RDAP nameserver names using validateDomainName 2017-10-24 16:53:47 -04:00
RdapNameserverActionTest.java Don't validate RDAP nameserver names using validateDomainName 2017-10-24 16:53:47 -04:00
RdapNameserverSearchActionTest.java Don't validate RDAP nameserver names using validateDomainName 2017-10-24 16:53:47 -04:00
RdapSearchPatternTest.java Don't validate RDAP nameserver names using validateDomainName 2017-10-24 16:53:47 -04:00
RdapTestHelper.java Add more tests for RDAP contact data permissioning 2017-09-12 15:51:50 -04:00