google-nomulus/javatests/google/registry
mountford ac822053cc Change behavior when searching contacts by name
We no longer find contacts by name if the request is not authorized to see the name.

Several changes cascade from this. Previously, the code assumed that deleted contacts might still have full names, and therefore be searchable. This is not possible in all cases, because Datastore doesn't have the right index to find deleted contacts by name with a matching registrar. However, luckily, this situation can never occur, because contacts always have their name fields nulled out when they are deleted.

So instead, we simply ignore deleted records when searching by name, knowing that none can ever match.

The tests were then changed so that deleted records look the way the really will, meaning devoid of personal information.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172776926
2017-10-24 16:53:47 -04:00
..
backup Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
batch Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
bigquery Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
builddefs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
config Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
cron Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
dns Translate multi-part TLD zone names 2017-10-24 16:53:47 -04:00
export Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
flows Rename ClaimsCheckFlow to DomainClaimsCheckFlow 2017-10-24 16:53:47 -04:00
groups Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
keyring Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
mapreduce/inputs Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
model Convert domain label list code to use Java 8 streams features 2017-10-24 16:53:47 -04:00
module Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
monitoring Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
pricing Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
rdap Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
rde Remove reference to TLD in Locks' ResourceName 2017-10-24 16:53:47 -04:00
reporting Prepare ICANN reporting for production 2017-10-24 16:53:47 -04:00
request Prepare ICANN reporting for production 2017-10-24 16:53:47 -04:00
security Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
server Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
storage/drive Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
testing Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
tldconfig/idn Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
tmch Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
tools Migrates users from the unitless, ambiguous plus(long) and minus(long) methods on various Joda-Time APIs to their Duration-accepting overloads. 2017-10-24 16:53:47 -04:00
ui Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
util Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
whois Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
xjc Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
xml Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00