mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 04:27:51 +02:00
This CL changes the domain and contact transfer flows to check the entire TransferData on the post-transfer resource, rather than just spot-checking certain fields. This approach provides much better code coverage - in particular, it checks that the non-request flows (approve, cancel, reject) don't modify the fields that they shouldn't be modifying, and that they do actually clear out the transfer server-approve entities fields written by the transfer request flow. It's slightly orthogonal, but I also added testing that the server-approve entities fields are actually set in the request flows, which was previously untested. This is pre-work for introducing an exDate-storing field into TransferData, by making it easier to test everywhere that exDate is set *and* unset only in the correct places. As part of this CL, I've introduced a TransferData.copyConstantFieldsToBuilder() method that is like asBuilder() but instead of copying all the fields to the new builder, it only copies the logically constant ones: losing/gaining client IDs, the request time and TRID, and transferPeriod. This is useful both in tests but is also used in the resolvingPendingTransfer() helper that centralizes the core transfer resolution logic (as of [] That method has its own tests, and in the process I removed a bunch of crufty defunct TransferData tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171053454
153 lines
4.9 KiB
Java
153 lines
4.9 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.testing;
|
|
|
|
import static com.google.common.base.Preconditions.checkNotNull;
|
|
import static com.google.common.truth.Truth.assertAbout;
|
|
|
|
import com.google.common.truth.FailureStrategy;
|
|
import com.google.common.truth.SimpleSubjectBuilder;
|
|
import google.registry.model.contact.ContactResource;
|
|
import google.registry.model.contact.PostalInfo;
|
|
import google.registry.model.eppcommon.AuthInfo;
|
|
import google.registry.testing.TruthChainer.And;
|
|
import org.joda.time.DateTime;
|
|
|
|
/** Truth subject for asserting things about {@link ContactResource} instances. */
|
|
public final class ContactResourceSubject
|
|
extends AbstractEppResourceSubject<ContactResource, ContactResourceSubject> {
|
|
|
|
/** A factory for instances of this subject. */
|
|
private static class SubjectFactory
|
|
extends ReflectiveSubjectFactory<ContactResource, ContactResourceSubject>{}
|
|
|
|
public ContactResourceSubject(FailureStrategy strategy, ContactResource subject) {
|
|
super(strategy, checkNotNull(subject));
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasLocalizedPostalInfo(PostalInfo postalInfo) {
|
|
return hasValue(postalInfo, actual().getLocalizedPostalInfo(), "has localizedPostalInfo");
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNullLocalizedPostalInfo() {
|
|
if (actual().getLocalizedPostalInfo() != null) {
|
|
fail("has null localized postal info");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNonNullLocalizedPostalInfo() {
|
|
if (actual().getLocalizedPostalInfo() == null) {
|
|
fail("has non-null localized postal info");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasInternationalizedPostalInfo(
|
|
PostalInfo postalInfo) {
|
|
return hasValue(
|
|
postalInfo,
|
|
actual().getInternationalizedPostalInfo(),
|
|
"has internationalizedPostalInfo");
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNullInternationalizedPostalInfo() {
|
|
if (actual().getInternationalizedPostalInfo() != null) {
|
|
fail("has null internationalized postal info");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
|
|
public And<ContactResourceSubject> hasNonNullInternationalizedPostalInfo() {
|
|
if (actual().getInternationalizedPostalInfo() == null) {
|
|
fail("has non-null internationalized postal info");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNullEmailAddress() {
|
|
if (actual().getEmailAddress() != null) {
|
|
fail("has null email address");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNonNullEmailAddress() {
|
|
if (actual().getEmailAddress() == null) {
|
|
fail("has non-null email address");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNullVoiceNumber() {
|
|
if (actual().getVoiceNumber() != null) {
|
|
fail("has null voice number");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNonNullVoiceNumber() {
|
|
if (actual().getVoiceNumber() == null) {
|
|
fail("has non-null voice number");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNullFaxNumber() {
|
|
if (actual().getFaxNumber() != null) {
|
|
fail("has null fax number");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasNonNullFaxNumber() {
|
|
if (actual().getFaxNumber() == null) {
|
|
fail("has non-null fax number");
|
|
}
|
|
return andChainer();
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasAuthInfoPwd(String pw) {
|
|
AuthInfo authInfo = actual().getAuthInfo();
|
|
return hasValue(pw, authInfo == null ? null : authInfo.getPw().getValue(), "has auth info pw");
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasLastTransferTime(DateTime lastTransferTime) {
|
|
return hasValue(
|
|
lastTransferTime,
|
|
actual().getLastTransferTime(),
|
|
"has lastTransferTime");
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasLastTransferTimeNotEqualTo(DateTime lastTransferTime) {
|
|
return doesNotHaveValue(
|
|
lastTransferTime,
|
|
actual().getLastTransferTime(),
|
|
"lastTransferTime");
|
|
}
|
|
|
|
public And<ContactResourceSubject> hasCurrentSponsorClientId(String clientId) {
|
|
return hasValue(
|
|
clientId,
|
|
actual().getCurrentSponsorClientId(),
|
|
"has currentSponsorClientId");
|
|
}
|
|
|
|
public static SimpleSubjectBuilder<ContactResourceSubject, ContactResource>
|
|
assertAboutContacts() {
|
|
return assertAbout(new SubjectFactory());
|
|
}
|
|
}
|