zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-02 04:57:51 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/testing
History
nickfelt 7e68ffa16a Change transfer flow tests to assert on entire TransferData contents 
This CL changes the domain and contact transfer flows to check the entire
TransferData on the post-transfer resource, rather than just spot-checking
certain fields.  This approach provides much better code coverage - in
particular, it checks that the non-request flows (approve, cancel, reject)
don't modify the fields that they shouldn't be modifying, and that they do
actually clear out the transfer server-approve entities fields written by
the transfer request flow.  It's slightly orthogonal, but I also added
testing that the server-approve entities fields are actually set in the
request flows, which was previously untested.

This is pre-work for introducing an exDate-storing field into TransferData,
by making it easier to test everywhere that exDate is set *and* unset only
in the correct places.

As part of this CL, I've introduced a TransferData.copyConstantFieldsToBuilder()
method that is like asBuilder() but instead of copying all the fields to the new
builder, it only copies the logically constant ones: losing/gaining client IDs,
the request time and TRID, and transferPeriod.  This is useful both in tests but
is also used in the resolvingPendingTransfer() helper that centralizes the core
transfer resolution logic (as of []  That method has its own tests,
and in the process I removed a bunch of crufty defunct TransferData tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=171053454
2017-10-05 11:44:46 -04:00
..
mapreduce Add mapreduce cleanup action 2017-03-13 10:24:57 -04:00
sftp Remove an unused exception 2017-02-02 17:06:50 -05:00
testdata Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
AbstractDomainBaseSubject.java Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
AbstractEppResourceSubject.java Add EppResource diffing to AbstractEppResourceSubject.isEqualTo() 2017-03-27 13:07:22 -04:00
AppEngineRule.java Remove all vestiges of memcache 2017-06-14 10:28:24 -04:00
BouncyCastleProviderRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Create an injectable LockHandler 2017-09-12 15:51:50 -04:00
CertificateSamples.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ContactResourceSubject.java Change transfer flow tests to assert on entire TransferData contents 2017-10-05 11:44:46 -04:00
DatastoreHelper.java Change transfer flow tests to assert on entire TransferData contents 2017-10-05 11:44:46 -04:00
default_premium_list_testdata.csv Don't allow duplicates in premium/reserved lists 2017-02-27 11:17:58 -05:00
DeterministicStringGenerator.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
DomainApplicationSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
DomainResourceSubject.java Change transfer flow tests to assert on entire TransferData contents 2017-10-05 11:44:46 -04:00
EppExceptionSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
EppLoader.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetricSubject.java Add more EPP metric lifecycle tests 2017-05-03 10:58:51 -04:00
ExceptionRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FailAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeClock.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeHttpSession.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeJsonResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeKeyringModule.java Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
FakeLockHandler.java Create an injectable LockHandler 2017-09-12 15:51:50 -04:00
FakeOAuthService.java Add more tests to new authentication framework 2017-02-27 11:19:27 -05:00
FakeResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletInputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeSleeper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeUserService.java Daggerize XsrfTokenManager 2017-02-22 11:43:10 -05:00
ForwardingURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FullFieldsTestEntityHelper.java Add RDAP support for deleted contacts and registrars 2017-10-04 16:16:45 -04:00
GcsTestingUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GenericEppResourceSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
GoldenFileTestHelper.java Add golden files for request component routing maps 2017-06-05 18:17:09 -04:00
GpgSystemCommandRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HistoryEntrySubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
HostResourceSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
InjectRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
IoSpyRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Lazies.java Make JSch injection lazy 2017-05-17 11:22:53 -04:00
logging.properties Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
LogsSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
package-info.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Providers.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveFieldExtractor.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveSubjectFactory.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ShardableTestCase.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SlurpAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemPropertyRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TaskQueueHelper.java Fix TaskQueueHelper param matching for pull queue tasks 2017-05-23 17:22:49 -04:00
TestDataHelper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TestLogHandlerUtils.java Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 2017-05-03 11:04:51 -04:00
TestObject.java Add @VirtualEntity checking to Ofy's deleteWithoutBackup() 2017-02-08 17:31:07 -05:00
TruthChainer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UriParameters.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UserInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00