google-nomulus/javatests/google/registry/dns
guyben 6bcd40f18a Remove "keepTasks" from ReadDnsQueueAction
"keepTasks" is a flag that prevents ReadDnsQueueAction from removing dns-update
tasks from the dns-pull queue, while still launching PublishDnsUpdates tasks to
update the DNS (meaning these tasks will be updated again in the next
ReadDnsQueueAction).

I'm not sure what's the purpose of this flag, but given we now allow multiple
writers (meaning we can already publish the same DNS multiple times) and given
that we can now recover from a bad writer (if a writer doesn't belong to a TLD,
we put the dns-updates queued for that writer back into the dns-pull queue) - I
suspect we don't need it anymore.

Alternative considered: changing this to a "dryRun" flag that won't actually
launch PublishDnsUpdates tasks, but will log which tasks it would have
launched. Decided against it because we will still need to "own" any task for a
significant amount of time if there are many (tens of thousands) tasks in the
queue. Hence a "dryRun" will still affect any actual runs for some time.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=183997187
2018-02-01 22:05:40 -05:00
..
writer Skip RRS update if existing records are equal to desired records 2017-12-27 11:18:21 -05:00
BUILD Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
DnsInjectionTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
DnsQueueTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
DnsTestComponent.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PublishDnsUpdatesActionTest.java Add label for the DnsWriter in the publishDnsUpdates metrics 2018-01-19 14:53:21 -05:00
ReadDnsQueueActionTest.java Remove "keepTasks" from ReadDnsQueueAction 2018-02-01 22:05:40 -05:00
RefreshDnsActionTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00