google-nomulus/javatests/google/registry
guyben 6bcd40f18a Remove "keepTasks" from ReadDnsQueueAction
"keepTasks" is a flag that prevents ReadDnsQueueAction from removing dns-update
tasks from the dns-pull queue, while still launching PublishDnsUpdates tasks to
update the DNS (meaning these tasks will be updated again in the next
ReadDnsQueueAction).

I'm not sure what's the purpose of this flag, but given we now allow multiple
writers (meaning we can already publish the same DNS multiple times) and given
that we can now recover from a bad writer (if a writer doesn't belong to a TLD,
we put the dns-updates queued for that writer back into the dns-pull queue) - I
suspect we don't need it anymore.

Alternative considered: changing this to a "dryRun" flag that won't actually
launch PublishDnsUpdates tasks, but will log which tasks it would have
launched. Decided against it because we will still need to "own" any task for a
significant amount of time if there are many (tens of thousands) tasks in the
queue. Hence a "dryRun" will still affect any actual runs for some time.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=183997187
2018-02-01 22:05:40 -05:00
..
backup Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
batch Migrate final try/catch test assertions to use assert/expectThrows 2018-01-19 14:43:12 -05:00
beam Move invoice generation to billing bucket and improve emailing 2018-01-19 14:34:14 -05:00
bigquery Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
builddefs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
config Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
cron Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
dns Remove "keepTasks" from ReadDnsQueueAction 2018-02-01 22:05:40 -05:00
export Migrate final try/catch test assertions to use assert/expectThrows 2018-01-19 14:43:12 -05:00
flows Consolidate some domain creation / deletion EPPs in testdata 2018-02-01 22:03:57 -05:00
groups Use method references when possible 2017-12-27 11:25:02 -05:00
keyring Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
mapreduce/inputs Migrate final try/catch test assertions to use assert/expectThrows 2018-01-19 14:43:12 -05:00
model Add dependencies on classes that are not in the default modules in JDK 9 2018-02-01 22:00:49 -05:00
module Refactor ICANN reporting and billing into common package 2018-02-01 21:56:06 -05:00
monitoring/whitebox Add dependencies on classes that are not in the default modules in JDK 9 2018-02-01 22:00:49 -05:00
pricing Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
proxy Add TokenStore and QuotaManager to manage proxy quota requests 2018-01-19 14:46:44 -05:00
rdap Add dependencies on classes that are not in the default modules in JDK 9 2018-02-01 22:00:49 -05:00
rde Add //third_party/java/jaxb dependency to targets using javax.xml.bind 2018-01-23 16:18:35 -05:00
reporting Refactor ICANN reporting and billing into common package 2018-02-01 21:56:06 -05:00
request Remove unnecessary type specifications 2017-12-27 11:23:03 -05:00
security Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
server Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
storage/drive Remove unnecessary type specifications 2017-12-27 11:23:03 -05:00
testing Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
tldconfig/idn Remove unnecessary type specifications 2017-12-27 11:23:03 -05:00
tmch Use method references instead of lambdas when possible 2017-12-27 10:55:03 -05:00
tools Add //third_party/java/jaxb dependency to targets using javax.xml.bind 2018-01-23 16:18:35 -05:00
ui Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
util Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
whois Migrate final try/catch test assertions to use assert/expectThrows 2018-01-19 14:43:12 -05:00
xjc Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
xml Add basic AllocationToken validation/redemption for domain creates 2018-01-19 14:28:26 -05:00