mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 12:37:52 +02:00
81dc2bbbc3
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
63 lines
2.3 KiB
Java
63 lines
2.3 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tmch;
|
|
|
|
import static google.registry.request.Action.Method.POST;
|
|
|
|
import google.registry.keyring.api.KeyModule.Key;
|
|
import google.registry.model.smd.SignedMarkRevocationList;
|
|
import google.registry.request.Action;
|
|
import google.registry.request.auth.Auth;
|
|
import google.registry.util.FormattingLogger;
|
|
import java.io.IOException;
|
|
import java.security.SignatureException;
|
|
import java.util.List;
|
|
import java.util.Optional;
|
|
import javax.inject.Inject;
|
|
import org.bouncycastle.openpgp.PGPException;
|
|
|
|
/** Action to download the latest signed mark revocation list from MarksDB. */
|
|
@Action(
|
|
path = "/_dr/task/tmchSmdrl",
|
|
method = POST,
|
|
automaticallyPrintOk = true,
|
|
auth = Auth.AUTH_INTERNAL_ONLY
|
|
)
|
|
public final class TmchSmdrlAction implements Runnable {
|
|
|
|
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
|
|
private static final String SMDRL_CSV_PATH = "/smdrl/smdrl-latest.csv";
|
|
private static final String SMDRL_SIG_PATH = "/smdrl/smdrl-latest.sig";
|
|
|
|
@Inject Marksdb marksdb;
|
|
@Inject @Key("marksdbSmdrlLogin") Optional<String> marksdbSmdrlLogin;
|
|
@Inject TmchSmdrlAction() {}
|
|
|
|
/** Synchronously fetches latest signed mark revocation list and saves it to Datastore. */
|
|
@Override
|
|
public void run() {
|
|
List<String> lines;
|
|
try {
|
|
lines = marksdb.fetchSignedCsv(marksdbSmdrlLogin, SMDRL_CSV_PATH, SMDRL_SIG_PATH);
|
|
} catch (SignatureException | IOException | PGPException e) {
|
|
throw new RuntimeException(e);
|
|
}
|
|
SignedMarkRevocationList smdrl = SmdrlCsvParser.parse(lines);
|
|
smdrl.save();
|
|
logger.infofmt(
|
|
"Inserted %,d smd revocations into Datastore, created at %s",
|
|
smdrl.size(), smdrl.getCreationTime());
|
|
}
|
|
}
|