mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 12:07:51 +02:00
"keepTasks" is a flag that prevents ReadDnsQueueAction from removing dns-update tasks from the dns-pull queue, while still launching PublishDnsUpdates tasks to update the DNS (meaning these tasks will be updated again in the next ReadDnsQueueAction). I'm not sure what's the purpose of this flag, but given we now allow multiple writers (meaning we can already publish the same DNS multiple times) and given that we can now recover from a bad writer (if a writer doesn't belong to a TLD, we put the dns-updates queued for that writer back into the dns-pull queue) - I suspect we don't need it anymore. Alternative considered: changing this to a "dryRun" flag that won't actually launch PublishDnsUpdates tasks, but will log which tasks it would have launched. Decided against it because we will still need to "own" any task for a significant amount of time if there are many (tens of thousands) tasks in the queue. Hence a "dryRun" will still affect any actual runs for some time. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=183997187 |
||
---|---|---|
.. | ||
com/google/testing/builddefs | ||
google/registry |