mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 20:47:52 +02:00
81dc2bbbc3
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
57 lines
1.7 KiB
Java
57 lines
1.7 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.dns.writer;
|
|
|
|
import google.registry.util.FormattingLogger;
|
|
import java.util.HashSet;
|
|
import java.util.Set;
|
|
import javax.inject.Inject;
|
|
|
|
/**
|
|
* {@link DnsWriter} that doesn't actually update records in a DNS server.
|
|
*
|
|
* <p>All this class does is write its displeasure to the logs.
|
|
*/
|
|
public final class VoidDnsWriter extends BaseDnsWriter {
|
|
|
|
/**
|
|
* The name of the pricing engine, as used in {@code Registry.dnsWriter}. Remember to change
|
|
* the value on affected Registry objects to prevent runtime failures.
|
|
*/
|
|
public static final String NAME = "VoidDnsWriter";
|
|
|
|
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
|
|
|
|
private final Set<String> names = new HashSet<>();
|
|
|
|
@Inject
|
|
public VoidDnsWriter() {}
|
|
|
|
@Override
|
|
public void publishDomain(String domainName) {
|
|
names.add(domainName);
|
|
}
|
|
|
|
@Override
|
|
public void publishHost(String hostName) {
|
|
names.add(hostName);
|
|
}
|
|
|
|
@Override
|
|
protected void commitUnchecked() {
|
|
logger.warningfmt(
|
|
"No DnsWriterFactory implementation specified; ignoring names to commit: %s", names);
|
|
}
|
|
}
|