mirror of
https://github.com/google/nomulus.git
synced 2025-05-05 14:37:52 +02:00
This is safer and addresses a common source of confusion in the codebase because it's always explicit that the resource returned may not be present, whether because it's soft-deleted when projected to the given time or because it never existed in the first place. In production code, the presence of the returned value is always checked. In test code, its presence is assumed using .get() where that is expected and convenient, as it not being present will throw an NPE that will cause the test to fail anyway. Note that the roughly equivalent reloadResourceByForeignKey(), which is widely used in test code, is not having this same treatment applied to it. That is out of the scope of this CL, and has much smaller returns anyway because it's only used in tests (where the unexpected absence of a given resource would just cause the test to fail). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=225424002
123 lines
4.8 KiB
Java
123 lines
4.8 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.eppcommon.StatusValue.SERVER_DELETE_PROHIBITED;
|
|
import static google.registry.model.eppcommon.StatusValue.SERVER_TRANSFER_PROHIBITED;
|
|
import static google.registry.model.eppcommon.StatusValue.SERVER_UPDATE_PROHIBITED;
|
|
import static google.registry.testing.DatastoreHelper.newDomainResource;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveDomain;
|
|
import static google.registry.testing.DatastoreHelper.persistNewRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.common.collect.ImmutableMap;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import google.registry.model.registrar.Registrar.Type;
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link UnlockDomainCommand}. */
|
|
public class UnlockDomainCommandTest extends EppToolCommandTestCase<UnlockDomainCommand> {
|
|
|
|
@Before
|
|
public void before() {
|
|
eppVerifier.expectSuperuser();
|
|
persistNewRegistrar("adminreg", "Admin Registrar", Type.REAL, 693L);
|
|
command.registryAdminClientId = "adminreg";
|
|
}
|
|
|
|
private static void persistLockedDomain(String domainName) {
|
|
persistResource(
|
|
newDomainResource(domainName)
|
|
.asBuilder()
|
|
.addStatusValues(
|
|
ImmutableSet.of(
|
|
SERVER_DELETE_PROHIBITED, SERVER_TRANSFER_PROHIBITED, SERVER_UPDATE_PROHIBITED))
|
|
.build());
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_sendsCorrectEppXml() throws Exception {
|
|
persistLockedDomain("example.tld");
|
|
runCommandForced("--client=NewRegistrar", "example.tld");
|
|
eppVerifier.verifySent("domain_unlock.xml", ImmutableMap.of("DOMAIN", "example.tld"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_partiallyUpdatesStatuses() throws Exception {
|
|
persistResource(
|
|
newDomainResource("example.tld")
|
|
.asBuilder()
|
|
.addStatusValues(ImmutableSet.of(SERVER_DELETE_PROHIBITED, SERVER_UPDATE_PROHIBITED))
|
|
.build());
|
|
runCommandForced("--client=NewRegistrar", "example.tld");
|
|
eppVerifier.verifySent("domain_unlock_partial_statuses.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_manyDomains() throws Exception {
|
|
// Create 26 domains -- one more than the number of entity groups allowed in a transaction (in
|
|
// case that was going to be the failure point).
|
|
List<String> domains = new ArrayList<>();
|
|
for (int n = 0; n < 26; n++) {
|
|
String domain = String.format("domain%d.tld", n);
|
|
persistLockedDomain(domain);
|
|
domains.add(domain);
|
|
}
|
|
runCommandForced(
|
|
ImmutableList.<String>builder().add("--client=NewRegistrar").addAll(domains).build());
|
|
for (String domain : domains) {
|
|
eppVerifier.verifySent("domain_unlock.xml", ImmutableMap.of("DOMAIN", domain));
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_domainDoesntExist() {
|
|
IllegalArgumentException e =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> runCommandForced("--client=NewRegistrar", "missing.tld"));
|
|
assertThat(e).hasMessageThat().isEqualTo("Domain 'missing.tld' does not exist or is deleted");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_alreadyUnlockedDomain_performsNoAction() throws Exception {
|
|
persistActiveDomain("example.tld");
|
|
runCommandForced("--client=NewRegistrar", "example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_defaultsToAdminRegistrar_ifUnspecified() throws Exception {
|
|
persistLockedDomain("example.tld");
|
|
runCommandForced("example.tld");
|
|
eppVerifier
|
|
.expectClientId("adminreg")
|
|
.verifySent("domain_unlock.xml", ImmutableMap.of("DOMAIN", "example.tld"));
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_duplicateDomainsAreSpecified() {
|
|
IllegalArgumentException e =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> runCommandForced("--client=NewRegistrar", "dupe.tld", "dupe.tld"));
|
|
assertThat(e).hasMessageThat().isEqualTo("Duplicate domain arguments found: 'dupe.tld'");
|
|
}
|
|
}
|