zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-02 07:52:11 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/tools
History
mcilwain 4491b7b909 Make loadByForeignKey() and related methods return Optional 
This is safer and addresses a common source of confusion in the codebase because it's always explicit that the resource returned may not be present, whether because it's soft-deleted when projected to the given time or because it never existed in the first place.

In production code, the presence of the returned value is always checked. In test code, its presence is assumed using .get() where that is expected and convenient, as it not being present will throw an NPE that will cause the test to fail anyway.

Note that the roughly equivalent reloadResourceByForeignKey(), which is widely used in test code, is not having this same treatment applied to it. That is out of the scope of this CL, and has much smaller returns anyway because it's only used in tests (where the unexpected absence of a given resource would just cause the test to fail).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=225424002
2018-12-14 11:24:49 -05:00
..
params Rename "absent" to "empty" in test names 2018-08-10 13:46:48 -04:00
server Remove the ability to download service account credentials 2018-12-05 16:00:51 -05:00
testdata Update signed marks files and add an expiration test 2018-06-27 15:28:53 -04:00
AllocateDomainCommandTest.java Refactor EppXmlTransformer to be in the model/ package 2018-12-12 13:22:34 -05:00
AuthModuleTest.java Use local credential to deploy beam pipelines 2018-12-05 16:07:54 -05:00
BUILD Add an unrenew_domain command to nomulus tool 2018-12-12 13:22:34 -05:00
CheckDomainClaimsCommandTest.java Default to admin registrar in check_domain commands 2018-09-08 00:19:53 -04:00
CheckDomainCommandTest.java Default to admin registrar in check_domain commands 2018-09-08 00:19:53 -04:00
CommandTestCase.java Add an unrenew_domain command to nomulus tool 2018-12-12 13:22:34 -05:00
ComparableEntityTest.java Clean up some areas in preparation for externalized codebase 2018-11-16 16:51:11 -05:00
CompareDbBackupsTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
CountDomainsCommandTest.java Add nomulus count_domains command 2018-05-05 23:37:11 -04:00
CreateAnchorTenantCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateCdnsTldTest.java Use @DefaultCredential for Cloud API access in GAE 2018-09-20 11:19:36 -04:00
CreateContactCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateDomainCommandTest.java Allow square bracket expansion when specifying nameservers 2018-08-10 13:44:25 -04:00
CreateHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateOrUpdatePremiumListCommandTestCase.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
CreateOrUpdateReservedListCommandTestCase.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreatePremiumListCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
CreateRegistrarCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
CreateRegistrarGroupsCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
CreateReservedListCommandTest.java Remove more unnecessary "throws" declarations 2018-06-27 15:28:52 -04:00
CreateTldCommandTest.java Remove the deprecated MISTAKEN_PREMIUM reservation type 2018-09-14 21:28:23 -04:00
CurlCommandTest.java Fix --content-type and --data inputs in curl command 2018-12-03 19:15:33 -05:00
DeleteAllocationTokensCommandTest.java Add nomulus command for deleting AllocationTokens 2018-10-03 11:54:10 -04:00
DeleteDomainCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeletePremiumListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteReservedListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteTldCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DomainApplicationInfoCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
EncryptEscrowDepositCommandTest.java Simplify the RyDE API 2018-07-17 22:03:53 -04:00
EppLifecycleToolsTest.java Make loadByForeignKey() and related methods return Optional 2018-12-14 11:24:49 -05:00
EppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
EppToolCommandTestCase.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
EppToolVerifier.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
ExecuteEppCommandTest.java Do not use InjectRule to mock stdin in ExecuteEppCommandTest 2018-10-22 18:46:36 -04:00
GenerateAllocationTokensCommandTest.java Increase default allocation token length to 16 2018-08-10 13:46:48 -04:00
GenerateAuctionDataCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GenerateDnsReportCommandTest.java Make loadByForeignKey() and related methods return Optional 2018-12-14 11:24:49 -05:00
GenerateEscrowDepositCommandTest.java Wrap ModulesService in new AppEngineServiceUtils 2018-08-10 13:44:25 -04:00
GetApplicationCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetApplicationIdsCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetClaimsListCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
GetContactCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetDomainCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetHistoryEntriesCommandTest.java Pretty-print actual XML in tests 2018-07-14 01:37:03 -04:00
GetHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetRegistrarCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetResourceByKeyCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetSchemaTreeCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
GetTldCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GhostrydeCommandTest.java Simplify the Ghostryde API 2018-06-27 15:28:53 -04:00
GtechToolTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
LevelDbFileBuilder.java Implement compare_db_backups "main" 2017-09-20 10:27:17 -04:00
LevelDbFileBuilderTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
LevelDbLogReaderTest.java Create an entity record accumulator 2017-09-12 15:51:50 -04:00
LevelDbUtil.java Clean up some code quality issues 2017-12-01 22:14:06 -05:00
ListCursorsCommandTest.java Add an auto update time field to the Cursor entity 2018-08-10 13:44:25 -04:00
ListDomainsCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
ListHostsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListObjectsCommandTestCase.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
ListPremiumListsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListRegistrarsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListReservedListsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListTldsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
LoadTestCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
LockDomainCommandTest.java Make loadByForeignKey() and related methods return Optional 2018-12-14 11:24:49 -05:00
MutatingCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
MutatingEppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
NonMutatingEppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
RecordAccumulatorTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
RegistrarContactCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
RegistryToolEnvironmentTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
RegistryToolTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
RenewDomainCommandTest.java Add a nomulus renew_domain command 2018-06-06 15:16:09 -04:00
RequestFactoryModuleTest.java Use local GoogleCredential in the nomulus tool 2018-12-05 16:06:19 -05:00
ResaveEntitiesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
ResaveEnvironmentEntitiesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
ResaveEppResourcesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
SetNumInstancesCommandTest.java Add option --non_live_versions to set_num_instances command 2018-12-03 18:58:05 -05:00
SetupOteCommandTest.java Add registrar contact to OTE registrars 2018-10-22 18:58:06 -04:00
ShellCommandTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
UniformRapidSuspensionCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UnlockDomainCommandTest.java Make loadByForeignKey() and related methods return Optional 2018-12-14 11:24:49 -05:00
UnrenewDomainCommandTest.java Make loadByForeignKey() and related methods return Optional 2018-12-14 11:24:49 -05:00
UpdateApplicationStatusCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateClaimsNoticeCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateCursorsCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateDomainCommandTest.java Allow square bracket expansion when specifying nameservers 2018-08-10 13:44:25 -04:00
UpdatePremiumListCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00
UpdateRegistrarCommandTest.java Handle Purchase Order numbers explicitly in billing pipeline 2018-09-20 11:19:36 -04:00
UpdateReservedListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateServerLocksCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateSmdCommandTest.java Refactor TmchCertificateAuthority 2018-10-25 14:40:38 -04:00
UpdateTldCommandTest.java Remove the deprecated MISTAKEN_PREMIUM reservation type 2018-09-14 21:28:23 -04:00
UploadClaimsListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
ValidateEscrowDepositCommandTest.java Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
ValidateLoginCredentialsCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
VerifyOteCommandTest.java Refactor AppEngineConnection 2018-10-29 15:34:12 -04:00