google-nomulus/java/google/registry
cgoldfeder 223e8c2316 Fix a null check bug in HostUpdateFlow
This bug is about a bad use of Optional.
We were checking == null instead of .isPresent(), so the check
always passed, and we always set a lastSubordinateTime when
updating hosts, even if the host was external and should have
had a null value in that field.

There is almost certainly bad data in prod in the sense
that any external host that was ever updated will have a value
for this field instead of null. However, this is not
consequential as the field is entirely meaningless for
external hosts, and will be properly reset if the host is
ever moved to be internal.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=146363178
2017-02-02 17:16:32 -05:00
..
backup Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
batch Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
bigquery Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
braintree Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
builddefs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
config Convert yet more configuration options to YAML 2017-02-02 17:05:28 -05:00
cron Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
dns Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
eclipse Restructure Maven dependencies in build 2017-01-09 11:59:04 -05:00
env Daggerize ExportSnapshotServlet and CheckSnapshotServlet 2017-01-30 15:03:53 -05:00
export Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
flows Fix a null check bug in HostUpdateFlow 2017-02-02 17:16:32 -05:00
gcs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
groups Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
idn Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
keyring/api Javadoc fix 2017-02-02 16:55:51 -05:00
loadtest Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
mapreduce Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
model Replace Throwables.propagate and variants with Guava 20 versions 2017-02-02 17:01:23 -05:00
module Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
monitoring Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
pricing Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
rdap Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
rde Remove an unused exception 2017-02-02 17:04:06 -05:00
request Replace Throwables.propagate and variants with Guava 20 versions 2017-02-02 17:01:23 -05:00
security Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
storage/drive Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tldconfig/idn Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tmch Replace Throwables.propagate and variants with Guava 20 versions 2017-02-02 17:01:23 -05:00
tools Fix two Gauava 20 deprecations across the tools package 2017-02-02 16:54:28 -05:00
ui Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
util Replace Throwables.propagate and variants with Guava 20 versions 2017-02-02 17:01:23 -05:00
whois Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
xjc Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
xml Replace Throwables.propagate and variants with Guava 20 versions 2017-02-02 17:01:23 -05:00
BUILD Add initial implementation of YAML config file 2017-01-25 12:25:05 -05:00
repositories.bzl Update copyright year on all license headers 2017-02-02 16:27:22 -05:00