mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 04:27:51 +02:00
This bug is about a bad use of Optional. We were checking == null instead of .isPresent(), so the check always passed, and we always set a lastSubordinateTime when updating hosts, even if the host was external and should have had a null value in that field. There is almost certainly bad data in prod in the sense that any external host that was ever updated will have a value for this field instead of null. However, this is not consequential as the field is entirely meaningless for external hosts, and will be properly reset if the host is ever moved to be internal. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146363178 |
||
---|---|---|
.. | ||
com/google/testing/builddefs | ||
google/registry |