Commit graph

599 commits

Author SHA1 Message Date
jianglai
71d7a382f3 Change all references to Domain Registry to Nomulus
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136068582
2016-10-14 16:58:07 -04:00
shikhman
9695024f1b Add Stackdriver Monitoring info to the operational documentation
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136066350
2016-10-14 16:58:07 -04:00
mcilwain
3b1be73b7d Remove fulfilled TODO to backfill RDAP indexes
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136062327
2016-10-14 16:58:07 -04:00
mcilwain
6a738557fb Use Dagger to @Inject DnsQueue everywhere that is feasible
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136062053
2016-10-14 16:58:07 -04:00
mcilwain
a13f6aded8 Remove stale TODO on setting GoogleCredential data
We simply don't need to do this.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136058076
2016-10-14 16:58:07 -04:00
shikhman
77e826997d Add documentation about Guava to the code structure document
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136057514
2016-10-14 16:58:07 -04:00
mcilwain
7b9ce8e087 Inject RateLimiter in CloudDnsWriter
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136055927
2016-10-14 16:58:07 -04:00
cgoldfeder
70afce13fe Remove the fallback trid logic in DomainAllocateFlow.
There are no applications extant that predate the creationTrid field.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136047561
2016-10-14 16:58:07 -04:00
mountford
bffc98c6ea Add TLD extra delete flow logic
This CL implements the TLD-specific extra flow logic for Delete commands, including tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136042223
2016-10-14 16:58:07 -04:00
jianglai
a01f238565 Make getStdoutAsLines() protected for testing
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135963935
2016-10-14 16:58:07 -04:00
ctingue
4e0b6d36c4 Change lrpTldStates to Interval
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135957698
2016-10-14 16:58:07 -04:00
mcilwain
edbb8985e6 Add [] documentation to code structure doc
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135956133
2016-10-14 16:58:07 -04:00
mountford
8ce6b16de7 Add TLD extra renew flow logic
This CL implements the TLD-specific extra flow logic for Renew commands, including tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135950104
2016-10-14 16:58:07 -04:00
ctingue
dd9137fbd1 Rename LrpToken to LrpTokenEntity
This is to better distinguish between an LRP "token" (the string passed along in EPP) and the datastore entity that contains the token and all metadata.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135943480
2016-10-14 16:58:07 -04:00
mountford
1a9f91ed9e Add TLD extra create flow logic
This CL implements the TLD-specific extra flow logic for Create commands, including tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135922961
2016-10-14 16:58:07 -04:00
mcilwain
cfbf62ef4e Move ExceptionRule up to FlowTestCase
This removes a much larger number of independent field defs.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135846921
2016-10-14 16:58:07 -04:00
nickfelt
a500812a91 Remove overly broad try-catch in BaseDomainCreateFlow.createFlowRepoId()
This bit Hans as described in
https://groups.google.com/d/topic/nomulus-discuss/o897-hRP_3c/discussion

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135842526
2016-10-14 16:58:07 -04:00
mcilwain
ffc0552c15 Fix "the the" typo in Javadoc
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135827263
2016-10-14 16:58:07 -04:00
cgoldfeder
c59227bb76 Remove useless createdRepoId from logging
It is no longer needed since we don't do log-replay and it's
annoying to support in the flat flows.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135805088
2016-10-14 16:58:07 -04:00
cgoldfeder
2d518ed666 Move thrown.expect() right before the throwing statement
aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407
2016-10-14 16:58:07 -04:00
shikhman
f76bc70f91 Preserve test logs and test summary output for Kokoro CI runs
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135494972
2016-10-14 16:57:43 -04:00
cgoldfeder
f3a0b78145 Move thrown.expect() right before the throwing statement
aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407
2016-10-11 11:27:54 -04:00
cgoldfeder
cb8320ff40 Change @DoNotHydrate to work on fields, not types.
There was a circular reference when hydrating a domain with a
subordinate host, since the host references the domain. To fix
this, I redid @DoNotHydrate to be the way it should have been,
rather than the hack I had originally submitted. I also beefed
up the unit tests of the epp resource types to check for cycles.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135792416
2016-10-11 11:27:54 -04:00
Ben McIlwain
27ec47051e Readability nits
Minor readability nits

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135726729
2016-10-11 11:27:53 -04:00
cgoldfeder
049c636966 Add a missing verification to DomainApplicationUpdateFlow.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135712711
2016-10-11 11:27:53 -04:00
mcilwain
dfe0ba32cb Reduce Datastore load of delete prober data mapreduce
This eliminates the transactional load of ForeignKeyIndexes and
EppResourceIndexes, the latter of which was problematic because it is parented
on the EppResourceIndexBucket entity group, and can cause concurrent
modification exceptions on live code paths. By removing the transactional load
and only touching that entity group on the delete, the number of potential
concurrent modification exceptions is significantly reduced.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135706974
2016-10-11 11:27:49 -04:00
nickfelt
6bbfef9eb3 Remove [TOC] tags from markdown documentation
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135699339
2016-10-11 11:27:48 -04:00
mountford
718da70b71 Add TLD extra flow logic for update
This CL implements the TLD-specific extra flow logic for updates, with tests, based on the static helper classes of the previous CL.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135683537
2016-10-11 11:27:48 -04:00
mcilwain
94c549d960 Delete obsoleted non-batched DNS refresh on host rename action
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135681285
2016-10-11 11:27:48 -04:00
nickfelt
f7a205975f Improve minor readability aspects of Admin Tool docs
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135531947
2016-10-11 11:27:48 -04:00
nickfelt
12734a33b5 Clarify what "speculative" refers to in code structure docs
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135530585
2016-10-11 11:27:48 -04:00
mcilwain
222ccd912a Centralize creation of MapreduceRunner in unit tests
This also changes the default number of mapper shards in tests to 2, which is
the number of EppResourceIndex buckets in unit tests. Running more shards than
there are buckets causes unnecessary test load.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135520601
2016-10-11 11:27:41 -04:00
nickfelt
ec64f4799c Fix javadoc on DomainApplicationIndex to reflect recent change
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135516642
2016-10-11 11:08:56 -04:00
mcilwain
f9fe25f00a Use "Nomulus" name in documentation
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135509458
2016-10-11 11:04:41 -04:00
mmuller
86d8f35f79 Reflow markdown flow documentation to 80 characters
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135500481
2016-10-11 11:00:26 -04:00
mountford
b224a90a4c RDAP: Display truncation notice for large entity result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL (hopefully the last one) handles the fixes for entity (contact and registrar) searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135494283
2016-10-07 15:29:49 -04:00
mcilwain
49fd75300e Fix call to @CheckReturnValue method in tests that wasn't checking
The exception being thrown during the build is described here:
http://errorprone.info/bugpattern/CheckReturnValue. Since this is just in a test
class, the most expedient thing to do is ignore the error.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135492692
2016-10-07 15:29:49 -04:00
mcilwain
503a10bbf8 Fix type inference error in RdapDomainSearchAction
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135482307
2016-10-07 15:29:49 -04:00
cgoldfeder
fabbf8871c Fix more deprecated methods in truth tests
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135481064
2016-10-07 15:29:49 -04:00
cgoldfeder
a09d48a4a5 Decentralize how registry phase checks are done in flows
Very few flows actually check the phase. Push the checks down to the leaf
flows so that we can remove the inherited code from ResourceFlow and replace
it with utility methods. In the process, document and test two places that
throw the exception but did not previously test it.

This introduces a temporary hack in BaseDomainCreateFlow that does something
specific for DomainApplicationCreateFlow. It will go away literally tomorrow
when I flatten that flow.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135480538
2016-10-07 15:29:48 -04:00
mcilwain
aaa84d6ec6 Improve a few assertion fails in tests
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135479183
2016-10-07 15:29:48 -04:00
shikhman
b62e60ed7e Fix documentation error in architecture doc
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135411618
2016-10-07 15:29:48 -04:00
mountford
5c5499d598 RDAP: Display truncation notice for large nameserver result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL handles the fixes for nameserver searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135411617
2016-10-07 15:29:48 -04:00
mcilwain
43c67403fa Expurgate vestiges of superannuated flow hierarchy
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135407546
2016-10-07 15:29:48 -04:00
mountford
179bd22531 RDAP: Display truncation notice for large domain result sets
The ICAAN Operational Profile dictates that a notice be added to the RDAP search results response when there are more objects than the server's chosen result set size. This CL handles the fixes for domain searches.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135407203
2016-10-07 15:29:48 -04:00
mcilwain
5a4926323e Use try-with-resources pattern in RdeParserTest
This fixes a whole mess of Eclipse warnings about a Closeable not calling
close().

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135407085
2016-10-07 15:29:48 -04:00
mcilwain
64426d3c7c Clarify the relationship between project ids in RegistryConfigs
This makes it clear that the non-production environment project ids are all
constructed by adding a suffix to the production environment project id, and
makes it slightly easier to configure it for a new environment (because there is
only one string to change instead of two).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135406763
2016-10-07 15:29:48 -04:00
mcilwain
d4e4333c2e Remove stray unused injected field in ContactDeleteFlow
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135406351
2016-10-07 15:29:48 -04:00
mmuller
129cbe8103 Make product name driven from config in the console
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135399007
2016-10-07 15:29:48 -04:00
ctingue
74369b69be Fix build by adding missing LrpToken.metadata field to schema file
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135392862
2016-10-07 15:29:47 -04:00