zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-25 03:58:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Mitigate Cloud task retry problem (#2116)

Browse source 
* Mitigate Cloud task retry problem

Increase PublishSpec11Action start delay to avoid the need to retry.

The only other use case is invoice, which typically does not retry:
delay is 10 minutes, pipeline finishes within 7 minutes.
This commit is contained in:
Weimin Yu 2023-08-18 17:14:03 -04:00 • committed by GitHub
parent c32d831dd6
commit cfcafeefc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
core/src/main/java/google/registry/reporting/spec11/GenerateSpec11ReportAction.java
View file

@ -141,7 +141,8 @@ public class GenerateSpec11ReportAction implements Runnable {
jobId, jobId,
ReportingModule.PARAM_DATE, ReportingModule.PARAM_DATE,
date.toString()), date.toString()),
Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES))); // TODO(b/296582836): mitigating retry problem. Remove `+10` when bug is fixed.
Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES + 10)));
} }
response.setStatus(SC_OK); response.setStatus(SC_OK);
response.setPayload(String.format("Launched Spec11 pipeline: %s", jobId)); response.setPayload(String.format("Launched Spec11 pipeline: %s", jobId));

3
core/src/test/java/google/registry/reporting/spec11/GenerateSpec11ReportActionTest.java
View file

@ -93,7 +93,8 @@ class GenerateSpec11ReportActionTest extends BeamActionTestBase {
.scheduleTime( .scheduleTime(
clock clock
.nowUtc() .nowUtc()
.plus(Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES)))); // TODO(b/296582836): mitigating retry problem. Remove `+10` when bug is fixed.
.plus(Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES + 10))));
} }
@Test @Test