From cfcafeefc63df7ef69166eb1c69d5ed76050fe73 Mon Sep 17 00:00:00 2001 From: Weimin Yu Date: Fri, 18 Aug 2023 17:14:03 -0400 Subject: [PATCH] Mitigate Cloud task retry problem (#2116) * Mitigate Cloud task retry problem Increase PublishSpec11Action start delay to avoid the need to retry. The only other use case is invoice, which typically does not retry: delay is 10 minutes, pipeline finishes within 7 minutes. --- .../registry/reporting/spec11/GenerateSpec11ReportAction.java | 3 ++- .../reporting/spec11/GenerateSpec11ReportActionTest.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/google/registry/reporting/spec11/GenerateSpec11ReportAction.java b/core/src/main/java/google/registry/reporting/spec11/GenerateSpec11ReportAction.java index d92ba0f4a..57a97021f 100644 --- a/core/src/main/java/google/registry/reporting/spec11/GenerateSpec11ReportAction.java +++ b/core/src/main/java/google/registry/reporting/spec11/GenerateSpec11ReportAction.java @@ -141,7 +141,8 @@ public class GenerateSpec11ReportAction implements Runnable { jobId, ReportingModule.PARAM_DATE, date.toString()), - Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES))); + // TODO(b/296582836): mitigating retry problem. Remove `+10` when bug is fixed. + Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES + 10))); } response.setStatus(SC_OK); response.setPayload(String.format("Launched Spec11 pipeline: %s", jobId)); diff --git a/core/src/test/java/google/registry/reporting/spec11/GenerateSpec11ReportActionTest.java b/core/src/test/java/google/registry/reporting/spec11/GenerateSpec11ReportActionTest.java index ca534566f..000a139df 100644 --- a/core/src/test/java/google/registry/reporting/spec11/GenerateSpec11ReportActionTest.java +++ b/core/src/test/java/google/registry/reporting/spec11/GenerateSpec11ReportActionTest.java @@ -93,7 +93,8 @@ class GenerateSpec11ReportActionTest extends BeamActionTestBase { .scheduleTime( clock .nowUtc() - .plus(Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES)))); + // TODO(b/296582836): mitigating retry problem. Remove `+10` when bug is fixed. + .plus(Duration.standardMinutes(ReportingModule.ENQUEUE_DELAY_MINUTES + 10)))); } @Test