zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-28 07:13:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clean up a few lint warnings (#1324)

Browse source 
The build is generating the following lint warnings:

core/src/main/java/google/registry/flows/certs/CertificateChecker.java:246:
warning: [ReferenceEquality] Compariso
n using reference equality instead of value equality
        && (lastExpiringNotificationSentDate == START_OF_TIME
                                             ^
    (see https://errorprone.info/bugpattern/ReferenceEquality)
core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java:350:
warning: [UnnecessaryParenthes
es] These grouping parentheses are unnecessary; it is unlikely the code will
be misinterpreted without them
        .that(jpaTm().transact((() -> jpaTm().loadByEntity(contactResource))))
This commit is contained in:
Michael Muller 2021-09-17 09:15:48 -04:00 • committed by GitHub
parent 1d14e96c9b
commit 93b4b03322
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
core/src/main/java/google/registry/flows/certs/CertificateChecker.java
View file

@ -243,7 +243,7 @@ public class CertificateChecker {
* lastExpiringNotificationSentDate is greater than expirationWarningIntervalDays. * lastExpiringNotificationSentDate is greater than expirationWarningIntervalDays.
*/ */
return !lastValidDate.after(now.plusDays(expirationWarningDays).toDate()) return !lastValidDate.after(now.plusDays(expirationWarningDays).toDate())
&& (lastExpiringNotificationSentDate == START_OF_TIME && (lastExpiringNotificationSentDate.equals(START_OF_TIME)
|| !lastExpiringNotificationSentDate || !lastExpiringNotificationSentDate
.plusDays(expirationWarningIntervalDays) .plusDays(expirationWarningIntervalDays)
.toDate() .toDate()

2
core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java
View file

@ -347,7 +347,7 @@ public class ReplayCommitLogsToSqlActionTest {
mutation); mutation);
runAndAssertSuccess(persistenceTime.minusMinutes(1), 1, 1); runAndAssertSuccess(persistenceTime.minusMinutes(1), 1, 1);
assertAboutImmutableObjects() assertAboutImmutableObjects()
.that(jpaTm().transact((() -> jpaTm().loadByEntity(contactResource)))) .that(jpaTm().transact(() -> jpaTm().loadByEntity(contactResource)))
.isEqualExceptFields(contactResource, "revisions"); .isEqualExceptFields(contactResource, "revisions");
} }