From 93b4b03322ae5a4aa1311fe95da19bf824ef56e5 Mon Sep 17 00:00:00 2001 From: Michael Muller Date: Fri, 17 Sep 2021 09:15:48 -0400 Subject: [PATCH] Clean up a few lint warnings (#1324) The build is generating the following lint warnings: core/src/main/java/google/registry/flows/certs/CertificateChecker.java:246: warning: [ReferenceEquality] Compariso n using reference equality instead of value equality && (lastExpiringNotificationSentDate == START_OF_TIME ^ (see https://errorprone.info/bugpattern/ReferenceEquality) core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java:350: warning: [UnnecessaryParenthes es] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them .that(jpaTm().transact((() -> jpaTm().loadByEntity(contactResource)))) --- .../java/google/registry/flows/certs/CertificateChecker.java | 2 +- .../google/registry/backup/ReplayCommitLogsToSqlActionTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/google/registry/flows/certs/CertificateChecker.java b/core/src/main/java/google/registry/flows/certs/CertificateChecker.java index c5b5090c6..4b84283e1 100644 --- a/core/src/main/java/google/registry/flows/certs/CertificateChecker.java +++ b/core/src/main/java/google/registry/flows/certs/CertificateChecker.java @@ -243,7 +243,7 @@ public class CertificateChecker { * lastExpiringNotificationSentDate is greater than expirationWarningIntervalDays. */ return !lastValidDate.after(now.plusDays(expirationWarningDays).toDate()) - && (lastExpiringNotificationSentDate == START_OF_TIME + && (lastExpiringNotificationSentDate.equals(START_OF_TIME) || !lastExpiringNotificationSentDate .plusDays(expirationWarningIntervalDays) .toDate() diff --git a/core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java b/core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java index fc5710f03..c8ecfd222 100644 --- a/core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java +++ b/core/src/test/java/google/registry/backup/ReplayCommitLogsToSqlActionTest.java @@ -347,7 +347,7 @@ public class ReplayCommitLogsToSqlActionTest { mutation); runAndAssertSuccess(persistenceTime.minusMinutes(1), 1, 1); assertAboutImmutableObjects() - .that(jpaTm().transact((() -> jpaTm().loadByEntity(contactResource)))) + .that(jpaTm().transact(() -> jpaTm().loadByEntity(contactResource))) .isEqualExceptFields(contactResource, "revisions"); }