zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-11 05:30:30 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add a 30s timeout for all webdriver tests (#161)

Browse source 
Sometimes, the webdriver tests get stuck forever for no reason. It could
be some issue in the test container but it is hard to root cause it. So,
adding a 30s timeout can either trigger the retry earlier or let the
test just fail.
This commit is contained in:
Shicong Huang 2019-07-09 14:42:32 -04:00 • committed by GitHub
parent 8dd6797614
commit 8371cb838c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/src/test/java/google/registry/webdriver/WebDriverTestCase.java
View file

@ -17,6 +17,7 @@ package google.registry.webdriver;
import google.registry.webdriver.RepeatableRunner.AttemptNumber; import google.registry.webdriver.RepeatableRunner.AttemptNumber;
import org.junit.ClassRule; import org.junit.ClassRule;
import org.junit.Rule; import org.junit.Rule;
import org.junit.rules.Timeout;
/** Base class for tests that needs a {@link WebDriverPlusScreenDifferRule}. */ /** Base class for tests that needs a {@link WebDriverPlusScreenDifferRule}. */
public class WebDriverTestCase { public class WebDriverTestCase {
@ -27,4 +28,7 @@ public class WebDriverTestCase {
@Rule @Rule
public final WebDriverPlusScreenDifferRule driver = public final WebDriverPlusScreenDifferRule driver =
new WebDriverPlusScreenDifferRule(webDriverProvider::getWebDriver, attemptNumber); new WebDriverPlusScreenDifferRule(webDriverProvider::getWebDriver, attemptNumber);
@Rule
public final Timeout timeout = Timeout.seconds(30);
} }