From 8371cb838ccaf73b431af16df2d4f3f5acaf3b06 Mon Sep 17 00:00:00 2001 From: Shicong Huang Date: Tue, 9 Jul 2019 14:42:32 -0400 Subject: [PATCH] Add a 30s timeout for all webdriver tests (#161) Sometimes, the webdriver tests get stuck forever for no reason. It could be some issue in the test container but it is hard to root cause it. So, adding a 30s timeout can either trigger the retry earlier or let the test just fail. --- .../java/google/registry/webdriver/WebDriverTestCase.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/src/test/java/google/registry/webdriver/WebDriverTestCase.java b/core/src/test/java/google/registry/webdriver/WebDriverTestCase.java index 70c0a385e..da8001c61 100644 --- a/core/src/test/java/google/registry/webdriver/WebDriverTestCase.java +++ b/core/src/test/java/google/registry/webdriver/WebDriverTestCase.java @@ -17,6 +17,7 @@ package google.registry.webdriver; import google.registry.webdriver.RepeatableRunner.AttemptNumber; import org.junit.ClassRule; import org.junit.Rule; +import org.junit.rules.Timeout; /** Base class for tests that needs a {@link WebDriverPlusScreenDifferRule}. */ public class WebDriverTestCase { @@ -27,4 +28,7 @@ public class WebDriverTestCase { @Rule public final WebDriverPlusScreenDifferRule driver = new WebDriverPlusScreenDifferRule(webDriverProvider::getWebDriver, attemptNumber); + + @Rule + public final Timeout timeout = Timeout.seconds(30); }