zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-15 17:07:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Use @Binds instead of @Provides for DnsWriter

Browse source 
It's just a pass-through, so @Binds is more efficient.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=199514776
This commit is contained in:
mcilwain 2018-06-06 12:59:35 -07:00 • committed by Ben McIlwain
parent 37095f82e9
commit 19f58f5557
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java
View file

@ -20,6 +20,7 @@ import com.google.api.client.json.JsonFactory;
import com.google.api.services.dns.Dns; import com.google.api.services.dns.Dns;
import com.google.api.services.dns.DnsScopes; import com.google.api.services.dns.DnsScopes;
import com.google.common.util.concurrent.RateLimiter; import com.google.common.util.concurrent.RateLimiter;
import dagger.Binds;
import dagger.Module; import dagger.Module;
import dagger.Provides; import dagger.Provides;
import dagger.multibindings.IntoMap; import dagger.multibindings.IntoMap;
@ -34,7 +35,7 @@ import javax.inject.Named;
/** Dagger module for Google Cloud DNS service connection objects. */ /** Dagger module for Google Cloud DNS service connection objects. */
@Module @Module
public final class CloudDnsWriterModule { public abstract class CloudDnsWriterModule {
@Provides @Provides
static Dns provideDns( static Dns provideDns(
@ -54,12 +55,10 @@ public final class CloudDnsWriterModule {
return builder.build(); return builder.build();
} }
@Provides @Binds
@IntoMap @IntoMap
@StringKey(CloudDnsWriter.NAME) @StringKey(CloudDnsWriter.NAME)
static DnsWriter provideWriter(CloudDnsWriter writer) { abstract DnsWriter provideWriter(CloudDnsWriter writer);
return writer;
}
@Provides @Provides
@IntoSet @IntoSet
@ -86,4 +85,6 @@ public final class CloudDnsWriterModule {
// NOTE: any number below 2 will not use threading at all. // NOTE: any number below 2 will not use threading at all.
return 10; return 10;
} }
private CloudDnsWriterModule() {}
} }