From 19f58f5557f0deeae9f1cd26056ad23198fdcb0f Mon Sep 17 00:00:00 2001
From: mcilwain <mcilwain@google.com>
Date: Wed, 6 Jun 2018 12:59:35 -0700
Subject: [PATCH] Use @Binds instead of @Provides for DnsWriter

It's just a pass-through, so @Binds is more efficient.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=199514776
---
 .../dns/writer/clouddns/CloudDnsWriterModule.java     | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java b/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java
index 8c54f08d1..f73d085c2 100644
--- a/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java
+++ b/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java
@@ -20,6 +20,7 @@ import com.google.api.client.json.JsonFactory;
 import com.google.api.services.dns.Dns;
 import com.google.api.services.dns.DnsScopes;
 import com.google.common.util.concurrent.RateLimiter;
+import dagger.Binds;
 import dagger.Module;
 import dagger.Provides;
 import dagger.multibindings.IntoMap;
@@ -34,7 +35,7 @@ import javax.inject.Named;
 
 /** Dagger module for Google Cloud DNS service connection objects. */
 @Module
-public final class CloudDnsWriterModule {
+public abstract class CloudDnsWriterModule {
 
   @Provides
   static Dns provideDns(
@@ -54,12 +55,10 @@ public final class CloudDnsWriterModule {
     return builder.build();
   }
 
-  @Provides
+  @Binds
   @IntoMap
   @StringKey(CloudDnsWriter.NAME)
-  static DnsWriter provideWriter(CloudDnsWriter writer) {
-    return writer;
-  }
+  abstract DnsWriter provideWriter(CloudDnsWriter writer);
 
   @Provides
   @IntoSet
@@ -86,4 +85,6 @@ public final class CloudDnsWriterModule {
     // NOTE: any number below 2 will not use threading at all.
     return 10;
   }
+
+  private CloudDnsWriterModule() {}
 }