zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-22 18:55:58 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix access to a nullable field in HistoryEntry (#1193)

Browse source 
* Fix access to a nullable field in HistoryEntry
This commit is contained in:
Weimin Yu 2021-06-04 16:30:25 -04:00 • committed by GitHub
parent 5f479488fa
commit 16392c3808
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/src/main/java/google/registry/model/reporting/HistoryEntry.java
View file

@ -61,6 +61,7 @@ import javax.persistence.EnumType;
import javax.persistence.Enumerated; import javax.persistence.Enumerated;
import javax.persistence.MappedSuperclass; import javax.persistence.MappedSuperclass;
import javax.persistence.Transient; import javax.persistence.Transient;
import org.apache.commons.lang3.BooleanUtils;
import org.joda.time.DateTime; import org.joda.time.DateTime;
/** /**
@ -435,7 +436,8 @@ public class HistoryEntry extends ImmutableObject implements Buildable, Datastor
checkArgumentNotNull(getInstance().modificationTime, "Modification time must be specified"); checkArgumentNotNull(getInstance().modificationTime, "Modification time must be specified");
checkArgumentNotNull(getInstance().clientId, "Registrar ID must be specified"); checkArgumentNotNull(getInstance().clientId, "Registrar ID must be specified");
checkArgument( checkArgument(
!getInstance().type.equals(Type.SYNTHETIC) || !getInstance().requestedByRegistrar, !getInstance().type.equals(Type.SYNTHETIC)
|| BooleanUtils.isNotTrue(getInstance().requestedByRegistrar),
"Synthetic history entries cannot be requested by a registrar"); "Synthetic history entries cannot be requested by a registrar");
return super.build(); return super.build();
} }