From 16392c3808e6c7522e495043d7e90dba06cfa033 Mon Sep 17 00:00:00 2001 From: Weimin Yu Date: Fri, 4 Jun 2021 16:30:25 -0400 Subject: [PATCH] Fix access to a nullable field in HistoryEntry (#1193) * Fix access to a nullable field in HistoryEntry --- .../java/google/registry/model/reporting/HistoryEntry.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/google/registry/model/reporting/HistoryEntry.java b/core/src/main/java/google/registry/model/reporting/HistoryEntry.java index 8d088912b..0bbeabaf1 100644 --- a/core/src/main/java/google/registry/model/reporting/HistoryEntry.java +++ b/core/src/main/java/google/registry/model/reporting/HistoryEntry.java @@ -61,6 +61,7 @@ import javax.persistence.EnumType; import javax.persistence.Enumerated; import javax.persistence.MappedSuperclass; import javax.persistence.Transient; +import org.apache.commons.lang3.BooleanUtils; import org.joda.time.DateTime; /** @@ -435,7 +436,8 @@ public class HistoryEntry extends ImmutableObject implements Buildable, Datastor checkArgumentNotNull(getInstance().modificationTime, "Modification time must be specified"); checkArgumentNotNull(getInstance().clientId, "Registrar ID must be specified"); checkArgument( - !getInstance().type.equals(Type.SYNTHETIC) || !getInstance().requestedByRegistrar, + !getInstance().type.equals(Type.SYNTHETIC) + || BooleanUtils.isNotTrue(getInstance().requestedByRegistrar), "Synthetic history entries cannot be requested by a registrar"); return super.build(); }