Merge branch 'master' of ssh://numinibsd/git/base/enigma-bbs

This commit is contained in:
Bryan Ashby 2015-12-13 17:44:48 -07:00
commit 6d172ae4ea
13 changed files with 26 additions and 233 deletions

View file

@ -1,182 +0,0 @@
/* jslint node: true */
'use strict';
var ansi = require('../core/ansi_term.js');
var art = require('../core/art.js');
var user = require('../core/user.js');
var theme = require('../core/theme.js');
var Log = require('../core/logger.js').log;
var MenuModule = require('../core/menu_module.js').MenuModule;
var ViewController = require('../core/view_controller.js').ViewController;
var Config = require('../core/config.js').config;
var sysMenuMethod = require('../core/system_menu_method.js');
var getDefaultMessageArea = require('../core/message_area.js').getDefaultMessageArea;
var util = require('util');
var async = require('async');
exports.submitApplication = submitApplication;
function validateApplicationData(formData, cb) {
// :TODO: This entire section should be replaced with a generic form validation system!!
async.waterfall(
[
function basics(callback) {
if(formData.value.username.length < Config.users.usernameMin) {
cb(new Error('Handle too short!'), [ 1 ]);
return;
}
if(formData.value.username.length > Config.users.usernameMax) {
cb(new Error('Handle too long!'), [ 1 ]);
return;
}
var re = new RegExp(Config.users.usernamePattern);
if(!re.test(formData.value.username)) {
cb(new Error('Handle contains invalid characters!'), [ 1 ] );
return;
}
var invalidNames = Config.users.newUserNames + Config.users.badUserNames;
if(invalidNames.indexOf(formData.value.username.toLowerCase()) > -1) {
cb(new Error('Handle is blacklisted!'), [ 1 ] );
return;
}
if(isNaN(Date.parse(formData.value.birthdate))) {
cb(new Error('Invalid birthdate!'), [ 3 ] );
return;
}
if(formData.value.password.length < Config.users.passwordMin) {
cb(new Error('Password too short!'), [ 9, 10 ]);
return;
}
if(formData.value.password !== formData.value.passwordConfirm) {
cb(new Error('Passwords do not match!'), [ 9, 10 ]);
return;
}
callback(null);
},
function email(callback) {
user.getUserIdsWithProperty('email_address', formData.value.email, function userIdsWithEmail(err, uids) {
if(err) {
callback(new Error('Internal system error: ' + err.toString()), [ 1 ]);
} else if(uids.length > 0) {
callback(new Error('Email address not unique!'), [ 7 ] );
} else {
callback(null);
}
});
},
function userName(callback) {
user.getUserIdAndName(formData.value.username, function userIdAndName(err) {
var alreadyExists = !err;
if(alreadyExists) {
callback(new Error('Username unavailable!'), [ 1 ] );
} else {
cb(null);
}
});
}
],
function complete(err, viewIds) {
cb(err, viewIds);
}
);
}
function submitApplication(callingMenu, formData, extraArgs) {
var client = callingMenu.client;
var menuConfig = callingMenu.menuConfig;
var menuViewController = callingMenu.viewControllers.menu;
var views = {
username : menuViewController.getView(1),
password : menuViewController.getView(9),
confirm : menuViewController.getView(10),
errorMsg : menuViewController.getView(11)
};
validateApplicationData(formData, function validationResult(err, viewIds) {
if(err) {
views.errorMsg.setText(err.toString().replace('Error: ', ''));
viewIds.forEach(function formId(id) {
menuViewController.getView(id).clearText('');
});
menuViewController.switchFocus(viewIds[0]);
} else {
// Seems legit!
// :TODO: All of this should be a system API, not a mod, e.g. createNewUser(...)
var newUser = new user.User();
newUser.username = formData.value.username;
newUser.properties = {
real_name : formData.value.realName,
birthdate : new Date(Date.parse(formData.value.birthdate)).toISOString(),
sex : formData.value.sex,
location : formData.value.location,
affiliation : formData.value.affils,
email_address : formData.value.email,
web_address : formData.value.web,
account_created : new Date().toISOString(),
message_area_name : getDefaultMessageArea().name,
term_height : client.term.termHeight,
term_width : client.term.termWidth,
// :TODO: This is set in User.create() -- proabbly don't need it here:
//account_status : Config.users.requireActivation ? user.User.AccountStatus.inactive : user.User.AccountStatus.active,
// :TODO: Other defaults
// :TODO: should probably have a place to create defaults/etc.
};
if('*' === Config.defaults.theme) {
newUser.properties.theme_id = theme.getRandomTheme();
} else {
newUser.properties.theme_id = Config.defaults.theme;
}
// :TODO: .create() should also validate email uniqueness!
newUser.create( { password : formData.value.password }, function created(err) {
if(err) {
Log.info( { error : err, username : formData.value.username }, 'New user creation failed');
callingMenu.gotoMenu(extraArgs.error, function result(err) {
if(err) {
callingMenu.prevMenu();
}
});
} else {
Log.info( { username : formData.value.username, userId : newUser.userId }, 'New user created');
// Cache SysOp information now
// :TODO: Similar to bbs.js. DRY
if(newUser.isSysOp()) {
Config.general.sysOp = {
username : formData.value.username,
properties : newUser.properties,
};
}
if(user.User.AccountStatus.inactive === client.user.properties.account_status) {
callingMenu.gotoMenu(extraArgs.inactive);
} else {
//
// If active now, we need to call login() to authenticate
//
sysMenuMethod.login(callingMenu, formData, extraArgs);
}
}
});
}
});
}

View file

@ -17,7 +17,7 @@ var _ = require('lodash');
userName
location
affiliation
timestamp
ts
*/

View file

@ -1,41 +0,0 @@
/* jslint node: true */
'use strict';
var MenuModule = require('../core/menu_module.js').MenuModule;
var ansi = require('../core/ansi_term.js');
exports.moduleInfo = {
name : 'LogOff',
desc : 'Log off / Goodbye Module',
author : 'NuSkooler',
};
exports.getModule = LogOffModule;
function LogOffModule(menuConfig) {
MenuModule.call(this, menuConfig);
}
require('util').inherits(LogOffModule, MenuModule);
LogOffModule.prototype.enter = function(client) {
LogOffModule.super_.prototype.enter.call(this, client);
};
LogOffModule.prototype.beforeArt = function() {
LogOffModule.super_.prototype.beforeArt.call(this);
this.client.term.write(ansi.resetScreen());
};
LogOffModule.prototype.mciReady = function(mciData) {
LogOffModule.super_.prototype.mciReady.call(this, mciData);
};
LogOffModule.prototype.finishedLoading = function() {
LogOffModule.super_.prototype.finishedLoading.call(this);
this.client.term.write(ansi.normal() + '\nATH0\n');
this.client.end();
};

View file

@ -131,7 +131,7 @@ MessageListModule.prototype.mciReady = function(mciData, cb) {
// :TODO: fix default format
var listFormat = self.menuConfig.config.listFormat || '{msgNum} - {subj} - {to}';
var focusListFormat = self.menuConfig.config.focusListFormat || listFormat; // :TODO: default change color here
var dateTimeFormat = self.menuConfig.config.dateTimeFormat || 'ddd MMM DDD';
var dateTimeFormat = self.menuConfig.config.dateTimeFormat || 'ddd MMM Do';
var newIndicator = self.menuConfig.config.newIndicator || '*';
var msgNum = 1;

View file

@ -146,7 +146,7 @@
config: {
listFormat: "|00|01|37{msgNum:>4} |00|37- |36{subj:<29.29} {from:<20.20} {ts} |01|31{newIndicator}"
focusListFormat: "|00|42|30{msgNum:>4} - {subj:<29.29} {from:<20.20} {ts} {newIndicator}"
dateTimeFormat: ddd MMM do
dateTimeFormat: ddd MMM Do
}
mci: {
VM1: {

View file

@ -71,13 +71,18 @@ WhosOnlineModule.prototype.mciReady = function(mciData, cb) {
var listFormat = self.menuConfig.config.listFormat || '{node} - {username} - {action} - {timeOn}';
var now = moment();
onlineListView.setItems(_.map(onlineList, function formatOnlineEntry(oe) {
return listFormat.format({
node : oe.node,
userId : oe.user.userId,
userName : oe.user.username,
realName : oe.user.properties.real_name,
timeOn : _.capitalize(moment.duration(55, 'minutes').humanize()),
timeOn : function getTimeOn() {
var diff = now.diff(moment(oe.user.properties.last_login_timestamp), 'minutes');
return _.capitalize(moment.duration(diff, 'minutes').humanize());
},
action : function getCurrentAction() {
var cmm = oe.currentMenuModule;
if(cmm) {