zydronium/enigma-bbs
1
0
Fork 0
mirror of https://github.com/NuSkooler/enigma-bbs.git synced 2025-07-22 10:45:56 +02:00
Code Issues Projects Releases Packages Wiki Activity

Some minor cleanup

Browse source
This commit is contained in:
Bryan Ashby 2018-12-31 11:33:14 -07:00
parent 0230d9958c
commit 4fb7c4bf53
1 changed files with 6 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

35
core/servers/login/telnet.js
View file

@ -16,8 +16,6 @@ const buffers = require('buffers');
const { Parser } = require('binary-parser'); const { Parser } = require('binary-parser');
const util = require('util'); const util = require('util');
//var debug = require('debug')('telnet');
const ModuleInfo = exports.moduleInfo = { const ModuleInfo = exports.moduleInfo = {
name : 'Telnet', name : 'Telnet',
desc : 'Telnet Server', desc : 'Telnet Server',
@ -36,24 +34,7 @@ exports.TelnetClient = TelnetClient;
/* /*
TODO: TODO:
* Document COMMANDS -- add any missing * Various (much lesser used) Telnet command coverage
* Document OPTIONS -- add any missing
* Internally handle OPTIONS:
* Some should be emitted generically
* Some should be handled internally -- denied, handled, etc.
*
* Allow term (ttype) to be set by environ sub negotiation
* Process terms in loop.... research needed
* Handle will/won't
* Handle do's, ..
* Some won't should close connection
* Options/Commands we don't understand shouldn't crash the server!!
*/ */
const COMMANDS = { const COMMANDS = {
@ -299,10 +280,7 @@ OPTION_IMPLS[OPTIONS.WINDOW_SIZE] = function(bufs, i, event) {
}; };
// Build an array of delimiters for parsing NEW_ENVIRONMENT[_DEP] // Build an array of delimiters for parsing NEW_ENVIRONMENT[_DEP]
const NEW_ENVIRONMENT_DELIMITERS = []; //const NEW_ENVIRONMENT_DELIMITERS = _.values(NEW_ENVIRONMENT_COMMANDS);
Object.keys(NEW_ENVIRONMENT_COMMANDS).forEach(function onKey(k) {
NEW_ENVIRONMENT_DELIMITERS.push(NEW_ENVIRONMENT_COMMANDS[k]);
});
// Handle the deprecated RFC 1408 & the updated RFC 1572: // Handle the deprecated RFC 1408 & the updated RFC 1572:
OPTION_IMPLS[OPTIONS.NEW_ENVIRONMENT_DEP] = OPTION_IMPLS[OPTIONS.NEW_ENVIRONMENT_DEP] =
@ -727,10 +705,9 @@ TelnetClient.prototype.handleSbCommand = function(evt) {
} }
}; };
const IGNORED_COMMANDS = []; const IGNORED_COMMANDS = [
[ COMMANDS.EL, COMMANDS.GA, COMMANDS.NOP, COMMANDS.DM, COMMANDS.BRK ].forEach(function onCommandCode(cc) { COMMANDS.EL, COMMANDS.GA, COMMANDS.NOP, COMMANDS.DM, COMMANDS.BRK
IGNORED_COMMANDS.push(cc); ];
});
TelnetClient.prototype.handleMiscCommand = function(evt) { TelnetClient.prototype.handleMiscCommand = function(evt) {
@ -750,7 +727,7 @@ TelnetClient.prototype.handleMiscCommand = function(evt) {
this.log.debug('Are You There (AYT) - Replied "\\b"'); this.log.debug('Are You There (AYT) - Replied "\\b"');
} else if(IGNORED_COMMANDS.indexOf(evt.commandCode)) { } else if(IGNORED_COMMANDS.indexOf(evt.commandCode)) {
this.log.debug({ evt : evt }, 'Ignoring command'); this.log.trace({ command : evt.command, commandCode : evt.commandCode }, 'Ignoring command');
} else { } else {
this.log.warn({ evt : evt }, 'Unknown command'); this.log.warn({ evt : evt }, 'Unknown command');
} }