zydronium/enigma-bbs
1
0
Fork 0
mirror of https://github.com/NuSkooler/enigma-bbs.git synced 2025-08-15 22:14:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

Don't return messages user doesn't have access to!

Browse source
This commit is contained in:
Bryan Ashby 2019-09-11 21:56:54 -06:00
parent d5268c7b9e
commit 4f6a0b175c
No known key found for this signature in database
GPG key ID: B49EB437951D2542
1 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

25
core/my_messages.js
View file

@ -5,6 +5,9 @@
const MenuModule = require('./menu_module.js').MenuModule; const MenuModule = require('./menu_module.js').MenuModule;
const Message = require('./message.js'); const Message = require('./message.js');
const UserProps = require('./user_property.js'); const UserProps = require('./user_property.js');
const {
hasMessageConfAndAreaRead
} = require('./message_area.js');
exports.moduleInfo = { exports.moduleInfo = {
name : 'My Messages', name : 'My Messages',
@ -30,7 +33,27 @@ exports.getModule = class MyMessagesModule extends MenuModule {
this.client.log.warn( { error : err.message }, 'Error finding messages addressed to current user'); this.client.log.warn( { error : err.message }, 'Error finding messages addressed to current user');
return this.prevMenu(); return this.prevMenu();
} }
this.messageList = messageList;
//
// We need to filter out messages belonging to conf/areas the user
// doesn't have access to.
//
// Keep a cache around for quick lookup.
//
const acsCache = new Map(); // areaTag:boolean
this.messageList = messageList.filter(msg => {
let cached = acsCache.get(msg.areaTag);
if(false === cached) {
return false;
}
if(true === cached) {
return true;
}
cached = hasMessageConfAndAreaRead(this.client, msg.areaTag);
acsCache.set(msg.areaTag, cached);
return cached;
});
this.finishedLoading(); this.finishedLoading();
}); });
} }