Minor logging improvements

This commit is contained in:
Tal Aloni 2017-08-27 14:46:39 +03:00
parent 5de5c91bb4
commit aa7ad0cd93
2 changed files with 3 additions and 3 deletions

View file

@ -72,7 +72,7 @@ namespace SMBLibrary
catch (Exception ex) catch (Exception ex)
{ {
NTStatus status = ToNTStatus(ex); NTStatus status = ToNTStatus(ex);
Log(Severity.Verbose, "SetFileInformation: Cannot rename '{0}'. {1}.", fileHandle.Path, status); Log(Severity.Verbose, "SetFileInformation: Cannot rename '{0}' to '{1}'. {2}.", fileHandle.Path, destination, status);
return status; return status;
} }
fileHandle.Path = destination; fileHandle.Path = destination;

View file

@ -93,13 +93,13 @@ namespace SMBLibrary.Server.SMB1
{ {
if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.OldFileName)) if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.OldFileName))
{ {
state.LogToServer(Severity.Verbose, "Rename '{0}{1}' failed. User '{2}' was denied access.", share.Name, request.OldFileName, session.UserName); state.LogToServer(Severity.Verbose, "Rename '{0}{1}' to '{0}{2}' failed. User '{3}' was denied access.", share.Name, request.OldFileName, request.NewFileName, session.UserName);
header.Status = NTStatus.STATUS_ACCESS_DENIED; header.Status = NTStatus.STATUS_ACCESS_DENIED;
return new ErrorResponse(request.CommandName); return new ErrorResponse(request.CommandName);
} }
if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.NewFileName)) if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.NewFileName))
{ {
state.LogToServer(Severity.Verbose, "Rename '{0}{1}' failed. User '{2}' was denied access.", share.Name, request.OldFileName, session.UserName); state.LogToServer(Severity.Verbose, "Rename '{0}{1}' to '{0}{2}' failed. User '{3}' was denied access.", share.Name, request.OldFileName, request.NewFileName, session.UserName);
header.Status = NTStatus.STATUS_ACCESS_DENIED; header.Status = NTStatus.STATUS_ACCESS_DENIED;
return new ErrorResponse(request.CommandName); return new ErrorResponse(request.CommandName);
} }