From aa7ad0cd93655a277d17bd182ea58593fb653772 Mon Sep 17 00:00:00 2001 From: Tal Aloni Date: Sun, 27 Aug 2017 14:46:39 +0300 Subject: [PATCH] Minor logging improvements --- SMBLibrary/NTFileStore/Adapter/NTFileSystemAdapter.Set.cs | 2 +- SMBLibrary/Server/SMB1/FileStoreResponseHelper.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/SMBLibrary/NTFileStore/Adapter/NTFileSystemAdapter.Set.cs b/SMBLibrary/NTFileStore/Adapter/NTFileSystemAdapter.Set.cs index 5935a3a..5ccdfc6 100644 --- a/SMBLibrary/NTFileStore/Adapter/NTFileSystemAdapter.Set.cs +++ b/SMBLibrary/NTFileStore/Adapter/NTFileSystemAdapter.Set.cs @@ -72,7 +72,7 @@ namespace SMBLibrary catch (Exception ex) { NTStatus status = ToNTStatus(ex); - Log(Severity.Verbose, "SetFileInformation: Cannot rename '{0}'. {1}.", fileHandle.Path, status); + Log(Severity.Verbose, "SetFileInformation: Cannot rename '{0}' to '{1}'. {2}.", fileHandle.Path, destination, status); return status; } fileHandle.Path = destination; diff --git a/SMBLibrary/Server/SMB1/FileStoreResponseHelper.cs b/SMBLibrary/Server/SMB1/FileStoreResponseHelper.cs index 4fa3919..c85c6aa 100644 --- a/SMBLibrary/Server/SMB1/FileStoreResponseHelper.cs +++ b/SMBLibrary/Server/SMB1/FileStoreResponseHelper.cs @@ -93,13 +93,13 @@ namespace SMBLibrary.Server.SMB1 { if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.OldFileName)) { - state.LogToServer(Severity.Verbose, "Rename '{0}{1}' failed. User '{2}' was denied access.", share.Name, request.OldFileName, session.UserName); + state.LogToServer(Severity.Verbose, "Rename '{0}{1}' to '{0}{2}' failed. User '{3}' was denied access.", share.Name, request.OldFileName, request.NewFileName, session.UserName); header.Status = NTStatus.STATUS_ACCESS_DENIED; return new ErrorResponse(request.CommandName); } if (!((FileSystemShare)share).HasWriteAccess(session.SecurityContext, request.NewFileName)) { - state.LogToServer(Severity.Verbose, "Rename '{0}{1}' failed. User '{2}' was denied access.", share.Name, request.OldFileName, session.UserName); + state.LogToServer(Severity.Verbose, "Rename '{0}{1}' to '{0}{2}' failed. User '{3}' was denied access.", share.Name, request.OldFileName, request.NewFileName, session.UserName); header.Status = NTStatus.STATUS_ACCESS_DENIED; return new ErrorResponse(request.CommandName); }