zydronium/screwturn-4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixes and closes #365: all SELECT queries have now a proper ORDER BY clause (especially ones with JOINs).

Browse source
This commit is contained in:
Dario Solera 2009-10-09 17:09:41 +00:00
parent 061207cb60
commit 4262bfd884
8 changed files with 43 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
SqlProvidersCommon/SqlSettingsStorageProviderBase.cs
View file

@ -157,6 +157,7 @@ namespace ScrewTurn.Wiki.Plugins.SqlCommon {
public IDictionary<string, string> GetAllSettings() {
ICommandBuilder builder = GetCommandBuilder();
// Sorting order is not relevant
string query = QueryBuilder.NewQuery(builder).SelectFrom("Setting");
DbCommand command = builder.GetCommand(connString, query, new List<Parameter>());
@ -705,6 +706,7 @@ namespace ScrewTurn.Wiki.Plugins.SqlCommon {
public string[] ListPluginAssemblies() {
ICommandBuilder builder = GetCommandBuilder();
// Sort order is not relevant
string query = QueryBuilder.NewQuery(builder).SelectFrom("PluginAssembly", new string[] { "Name" });
DbCommand command = builder.GetCommand(connString, query, new List<Parameter>());
@ -1095,6 +1097,7 @@ namespace ScrewTurn.Wiki.Plugins.SqlCommon {
private AclEntry[] LoadDataInternal() {
ICommandBuilder builder = GetCommandBuilder();
// Sort order is not relevant
string query = QueryBuilder.NewQuery(builder).SelectFrom("AclEntry");
DbCommand command = builder.GetCommand(connString, query, new List<Parameter>());
@ -1257,6 +1260,7 @@ namespace ScrewTurn.Wiki.Plugins.SqlCommon {
string query = queryBuilder.SelectFrom("OutgoingLink", new string[] { "Destination" });
query = queryBuilder.Where(query, "Source", WhereOperator.Equals, "Source");
query = queryBuilder.OrderBy(query, new[] { "Destination" }, new[] { Ordering.Asc });
List<Parameter> parameters = new List<Parameter>(1);
parameters.Add(new Parameter(ParameterType.String, "Source", page));