more work on commands

- moved script object to wrapper class to catch and log exceptions
- added loggers for basepacket/subpacket (todo: colour and use them in NLog.config)
- finished up most commands (todo: !property and !property2)
- todo: create and use mysql wrapper class to log exceptions

FFXIVClassic Map Server/actors/Actor.cs

@@ -377,6 +377,16 @@ namespace FFXIVClassic_Map_Server.Actors
             // todo: handle zone?
             zone.BroadcastPacketAroundActor(this, MoveActorToPositionPacket.BuildPacket(this.actorId, this.actorId, x, y, z, rot, moveState));
         }
+
+        public Area GetZone()
+        {
+            return zone;
+        }
+
+        public uint GetZoneID()
+        {
+            return zoneId;
+        }
     }
 }
 

FFXIVClassic Map Server/actors/area/Area.cs

@@ -13,7 +13,8 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
-
+using FFXIVClassic_Map_Server.packets.send;
+
 namespace FFXIVClassic_Map_Server.Actors
 {
     class Area : Actor
@@ -352,5 +353,25 @@ namespace FFXIVClassic_Map_Server.Actors
             AddActorToZone(npc);                          
         }
 
+        public void ChangeWeather(ushort weather, ushort transitionTime, Player player, bool zoneWide = false)
+        {
+            weatherNormal = weather;
+
+            if (player != null && !zoneWide)
+            {
+                player.QueuePacket(BasePacket.CreatePacket(SetWeatherPacket.BuildPacket(player.actorId, weather, transitionTime), true, false));
+            }
+            if (zoneWide)
+            {
+                foreach (var actor in mActorList)
+                {
+                    if (actor.Value is Player)
+                    {
+                        player = ((Player)actor.Value);
+                        player.QueuePacket(BasePacket.CreatePacket(SetWeatherPacket.BuildPacket(player.actorId, weather, transitionTime), true, false));
+                    }
+                }
+            }
+        }
     }
 }

FFXIVClassic Map Server/actors/chara/npc/Npc.cs

@@ -3,7 +3,7 @@ using FFXIVClassic_Map_Server.actors;
 using FFXIVClassic_Map_Server.Actors.Chara;
 using FFXIVClassic_Map_Server.dataobjects;
 using FFXIVClassic_Map_Server.lua;
-using FFXIVClassic_Map_Server.packets;
+using FFXIVClassic_Map_Server.packets;
 using FFXIVClassic_Map_Server.packets.receive.events;
 using FFXIVClassic_Map_Server.packets.send.actor;
 using FFXIVClassic_Map_Server.utils;

FFXIVClassic Map Server/actors/chara/player/Inventory.cs

@@ -87,15 +87,21 @@ namespace FFXIVClassic_Map_Server.actors.chara.player
             AddItem(itemId, quantity, 1);
         }
 
-        public void AddItem(uint itemId, int quantity, byte quality)
+        public bool AddItem(uint itemId, int quantity, byte quality)
         {
             if (!IsSpaceForAdd(itemId, quantity))
-                return;
+                return false;
 
             Item gItem = Server.GetItemGamedata(itemId);
             List<ushort> slotsToUpdate = new List<ushort>();
             List<SubPacket> addItemPackets = new List<SubPacket>();
 
+            if (gItem == null)
+            {
+                Program.Log.Error("Inventory.AddItem: unable to find item %u", itemId);
+                return false;
+            }
+
             //Check if item id exists 
             int quantityCount = quantity;
             for (int i = 0; i < list.Count; i++)
@@ -152,6 +158,7 @@ namespace FFXIVClassic_Map_Server.actors.chara.player
 
             owner.QueuePacket(InventorySetEndPacket.BuildPacket(owner.actorId));
             owner.QueuePacket(InventoryEndChangePacket.BuildPacket(owner.actorId));
+            return true;
         }
 
         public void AddItem(uint[] itemId)

FFXIVClassic Map Server/actors/chara/player/Player.cs

@@ -749,6 +749,26 @@ namespace FFXIVClassic_Map_Server.Actors
             //zone.BroadcastPacketAroundActor(this, worldMasterMessage);
         }
 
+        public void ChangeProperty(uint id, uint value, string target)
+        {
+            SetActorPropetyPacket ChangeProperty = new SetActorPropetyPacket(target);
+
+            ChangeProperty.SetTarget(target);
+            ChangeProperty.AddInt(id, value);
+            ChangeProperty.AddTarget();
+
+          /*foreach (KeyValuePair<uint, ConnectedPlayer> entry in mConnectedPlayerList)
+            {
+                SubPacket ChangePropertyPacket = ChangeProperty.BuildPacket((entry.Value.actorID), (entry.Value.actorID));
+
+                BasePacket packet = BasePacket.CreatePacket(ChangePropertyPacket, true, false);
+                packet.DebugPrintPacket();
+
+                entry.Value.QueuePacket(packet);
+            }
+          */
+        }
+
         public void GraphicChange(uint slot, uint graphicId)
         {
             appearanceIds[slot] = graphicId;