From d10713455c7c883d5523d52f71d4890338c03051 Mon Sep 17 00:00:00 2001 From: Kyle Drake Date: Tue, 20 Aug 2024 10:13:24 -0500 Subject: [PATCH] fix for tag creation with extra space --- models/site.rb | 2 +- tests/acceptance/signup_tests.rb | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/models/site.rb b/models/site.rb index 8801122c..9eedffec 100644 --- a/models/site.rb +++ b/models/site.rb @@ -1106,7 +1106,7 @@ class Site < Sequel::Model end if @new_tags_string - new_tags = @new_tags_string.split ',' + new_tags = @new_tags_string.strip.split ',' new_tags.compact! @new_filtered_tags = [] diff --git a/tests/acceptance/signup_tests.rb b/tests/acceptance/signup_tests.rb index 8dc0ad38..9917e0a2 100644 --- a/tests/acceptance/signup_tests.rb +++ b/tests/acceptance/signup_tests.rb @@ -173,6 +173,14 @@ describe 'signup' do _(Site.last.tags.collect {|t| t.name}).must_equal ['derpie', 'shoujo'] end + it 'succeeds with extra space in tags' do + fill_in_valid + fill_in 'new_tags_string', with: 'blinkies, music, programming, ' + click_signup_button + _(site_created?).must_equal true + _(Site.last.tags.collect {|t| t.name}).must_equal ['blinkies', 'music', 'programming'] + end + it 'fails with invalid tag chars' do fill_in_valid fill_in 'new_tags_string', with: '$POLICE OFFICER$$$$$, derp'