From b0c5c95b5e344537c2e7300f44b5bba2816c4bb7 Mon Sep 17 00:00:00 2001 From: Kyle Drake Date: Sat, 22 Apr 2017 17:30:40 -0700 Subject: [PATCH] Don't do expensive re-open of zip for each file add --- models/site.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/models/site.rb b/models/site.rb index 80eed12f..d7ca6926 100644 --- a/models/site.rb +++ b/models/site.rb @@ -777,12 +777,10 @@ class Site < Sequel::Model Zip::Archive.open(tmpfile.path, Zip::CREATE) do |ar| ar.add_dir(zip_name) - end - Dir.glob("#{base_files_path}/**/*").each do |path| - relative_path = path.gsub(base_files_path+'/', '') - - Zip::Archive.open(tmpfile.path, Zip::CREATE) do |ar| + Dir.glob("#{base_files_path}/**/*").each do |path| + relative_path = path.gsub(base_files_path+'/', '') + puts "adding #{relative_path}" if File.directory?(path) ar.add_dir(zip_name+'/'+relative_path) else