From 837b0ea2d0380617918253812c4266e5ac52b84d Mon Sep 17 00:00:00 2001
From: Kyle Drake <kyle@kyledrake.net>
Date: Fri, 5 Jan 2024 16:37:14 -0600
Subject: [PATCH] no hyphens at start or end of username

---
 models/site.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/models/site.rb b/models/site.rb
index 30971a84..80defff7 100644
--- a/models/site.rb
+++ b/models/site.rb
@@ -658,7 +658,7 @@ class Site < Sequel::Model
   end
 
   def self.valid_username?(username)
-    !username.empty? && username.match(/^[a-zA-Z0-9_\-]+$/i)
+    !username.empty? && username.match(/^[a-zA-Z0-9][a-zA-Z0-9_\-]+[a-zA-Z0-9]$/i)
   end
 
   def self.disposable_email_domains
@@ -986,7 +986,7 @@ class Site < Sequel::Model
     super
 
     if !self.class.valid_username?(values[:username])
-      errors.add :username, 'Usernames can only contain letters, numbers, and hyphens.'
+      errors.add :username, 'Usernames can only contain letters, numbers, and hyphens, and cannot start or end with a hyphen.'
     end
 
     if !values[:username].blank?